Skip to content

set a default value for axis parameter in dpnp.take_along_axis #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 14, 2025
Merged

set a default value for axis parameter in dpnp.take_along_axis #2442

merged 5 commits into from
May 14, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented May 12, 2025 •
edited by antonwolfy
Loading

set a default value of -1 for axis parameter in dpnp.take_along_axis

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this May 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 12, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented May 12, 2025 •
edited
Loading

Coverage Status

coverage: 71.692%. remained the same
when pulling 75e2d1f on take_along_axis
into a79d1ca on master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 12, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev2=py312he4f9c94_15 ran successfully.
Passed: 1229
Failed: 0
Skipped: 9

@vtavana vtavana marked this pull request as ready for review May 12, 2025 12:19
antonwolfy
antonwolfy reviewed May 12, 2025
View reviewed changes
antonwolfy
antonwolfy approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@antonwolfy antonwolfy added this to the 0.18.0 release milestone May 13, 2025
@antonwolfy antonwolfy merged commit a804dd7 into master May 14, 2025
56 of 66 checks passed
@antonwolfy antonwolfy deleted the take_along_axis branch May 14, 2025 19:15
github-actions bot added a commit that referenced this pull request May 14, 2025
@github-actions
set a default value for axis parameter in dpnp.take_along_axis (#2442)
9a23217 
Set a default value of `-1` for axis parameter in `dpnp.take_along_axis` a804dd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
0.18.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @coveralls @antonwolfy