Add dpnp.linalg.eigvalsh() implementation #1714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Feb 16, 2024
antonwolfy
reviewed
Feb 20, 2024
vlad-perevezentsev
force-pushed
the
impl_eigvalsh
branch
from
522750a to
fa6078e
Compare
antonwolfy
approved these changes
Apr 2, 2024
github-actions bot
added a commit
to antonwolfy/dpnp
that referenced
this pull request
Apr 4, 2024
* Add dpnp.linalg.eigvalsh() impl * Update cupy tests for dpnp.linalg.eigvalsh func * Small update dpnp.linalg.eigh * Update cupy tests for dpnp.linalg.eigh * Add test_eigenvalue_symm to check queue and usm_type * Update test_linalg.py * Optimize dpnp_eigh logic for eigen_mode='N' * Add a logic with a.size==0 to dpnp_eigh * Update docstrings for eigh and eigvalsh * Update cupy tests * Add support for both registers to UPLO * Call dpnp_eigh instead of dpnp_eigvalsh * Add get_symm_herm_numpy_array func to helper.py * Update dpnp tests * Add generate_random_numpy_array func to helper.py * Remove use_seed parameter from generate_random_numpy_array * Address remarks * Generate 4d and more array * Support 4d and more array for dpnp_eigh * Update TestEigenvalue * Fix invalid UPLO test * Make depends parameter optional in heevd.hpp * Add a w/a for MKLD-17201 * Wait for each host_task after calling _syevd * Update test_eigenvalues in test_linalg.py * Update test_eigenvalue in test_sycl_queue.py --------- Co-authored-by: Anton <[email protected]> 42f2644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
dpnp.linalg.eigvalsh()function to calculate the eigenvalues of a complex Hermitian or real symmetric matrix usingdpnp.linalg.eigh()Also the PR adds missing tests for
dpnp.linalg.eighslightly changes its implementation and its docstrings