Exclude docker image removal #1465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtavana
added a commit
that referenced
this pull request
Nov 9, 2023
vtavana
added a commit
that referenced
this pull request
Nov 23, 2023
* rework implementation of diag, diagflat, vander, and ptp * address comments - first round cherry-pick * address comments - second round * add tests for negative use cases to improve covergae * fixed missing merge conflicts * fix pre-commit * implement dpnp.argmin and dpnp.argmax using dpctl.tensor * address comments * add tests for negative use cases to improve coverage * remove unneccessary parts with updates in dpctl #1465 * add paramater section in doc * update ndarray.argmin and ndarray.argmax function signature * use a utility func for returning output * add tests for ndarray implementation * Place new function acc to lexicographical order --------- Co-authored-by: Anton Volkov <[email protected]> Co-authored-by: Anton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github action with a pre-step to free additional space during building the docs was updated with a new version and so it enabled docker image removal by default.
The PR proposal to explicitly disable removal of docker images, since the image is required.