Skip to content

fix_cov_for_no_fp64 #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2023
Merged

fix_cov_for_no_fp64 #1385

merged 2 commits into from
Apr 27, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 19, 2023 •
edited
Loading

closes issue #1379
In this PR, dpnp.cov is modified to work on GPUs that only support float32.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana force-pushed the fix_dpnp.cov_for_no_fp64 branch 2 times, most recently from 16f510d to a18c1db Compare April 20, 2023 17:14
@vtavana vtavana self-assigned this Apr 20, 2023
@vtavana vtavana added the in progress Please do not merge. Work is in progress. label Apr 20, 2023
@vtavana vtavana force-pushed the fix_dpnp.cov_for_no_fp64 branch from a18c1db to b340b2c Compare April 20, 2023 21:45
@vtavana vtavana added bug Something isn't working and removed in progress Please do not merge. Work is in progress. labels Apr 20, 2023
@vtavana vtavana requested a review from antonwolfy April 20, 2023 21:50
antonwolfy
antonwolfy reviewed Apr 21, 2023
View reviewed changes
@vtavana vtavana force-pushed the fix_dpnp.cov_for_no_fp64 branch from b340b2c to 5c46871 Compare April 24, 2023 15:49
antonwolfy
antonwolfy approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you @vtavana !

@vtavana vtavana force-pushed the fix_dpnp.cov_for_no_fp64 branch from 5c46871 to ac68ba2 Compare April 26, 2023 00:37
@vtavana vtavana force-pushed the fix_dpnp.cov_for_no_fp64 branch from ac68ba2 to 326a75e Compare April 26, 2023 13:56
@antonwolfy antonwolfy merged commit 1a3864e into master Apr 27, 2023
@antonwolfy antonwolfy deleted the fix_dpnp.cov_for_no_fp64 branch April 27, 2023 11:48
@vtavana vtavana mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vtavana vtavana

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy