Skip to content

Remove mixed host\dev implementation from dpnp.any() #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 1, 2023
Merged

Remove mixed host\dev implementation from dpnp.any() #1302

merged 3 commits into from
Mar 1, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Feb 16, 2023 •
edited
Loading

This PR proposes to update implementation of dpnp.any() and to make it compliant with compute follows data paradigm. It includes changes:

  • to get rid of unnecessary temporary memory copy into shared USM memory
  • to remove direct use of host memory when assigning a value into result array
  • to add missing DPCTLEvent_Delete() call in dpnp_any_c() API function
  • to rework the kernel function with subgroup and sycl::joint_any_of()
  • to support dpnp.complex64 and dpnp.complex128 data types

The PR continues work started in #1155 and is aimed to substitute it.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Feb 16, 2023
@antonwolfy antonwolfy merged commit 1c7b85f into IntelPython:master Mar 1, 2023
@antonwolfy antonwolfy deleted the cfd_any branch March 1, 2023 14:24
@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Mar 13, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @oleksandr-pavlyk