-
Notifications
You must be signed in to change notification settings - Fork 22
Add dlpack support #1296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
oleksandr-pavlyk
merged 4 commits into
IntelPython:master
from
vlad-perevezentsev:dlpack_support
Feb 16, 2023
Merged
Add dlpack support #1296
oleksandr-pavlyk
merged 4 commits into
IntelPython:master
from
vlad-perevezentsev:dlpack_support
Feb 16, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
antonwolfy
reviewed
Feb 14, 2023
Looks good to me. I built the branch, tested few inputs:
While testing I also discovered an issue in |
oleksandr-pavlyk
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We should test that it works with mpi4py before merging though
681fd63
to
4c158da
Compare
antonwolfy
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1291
The PR adds dlpack and dlpack_device protocols to dpnp_array and implements dpnp.from_dlpack function including tests and docstrings.