Merge changes for nightly tests in CI #1209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pter
The reason this crashed with CPU device and gave incorrect results on
Windows was deeper.
1. Adapter call allocated USM-shared buffer and copies data into it
2. Kernel is submitted to work on USM-shared pointer
3. dpnp_take_c returns kernel submission even
4. Adapter class goes out of scope and frees USM allocation
without making sure that the kernel that works on it has completed
its execution
5. If kernel execution was in progress we got a crash on CPU, or
incorrect result on GPU
If kernel execution was complete it worked as expected.
This change fixes the problem because it removes creation of unprotected
USM-shared temporary.
…t depend The deallocation routine simply calls sycl::event::wait on the stored vector.
Also applied DPCTLEvent_Delete in legacy interfaces to avoid memory leak.
Add a null-terminated symbol at the end of char array to avoid "Improper Null Termination" issue reported by Checkmarx scan.
Co-authored-by: Oleksandr Pavlyk <[email protected]>
Co-authored-by: Oleksandr Pavlyk <[email protected]>
Get rid of "Improper Null Termination" issue
* Skip for two more tests till waiting fix tests/third_party/cupy/statistics_tests/test_order.py::TestOrder::test_ptp_all_nan tests/third_party/cupy/statistics_tests/test_order.py::TestOrder::test_ptp_nan Need to skip them because CI does not work due to this. * The same tests skip for gpu
* dpnp_take failed on Windows due to memory corruption * Add more tests * Integer indexes types with different types of input data * Add trailing empty line to .gitignore
Fix typo Relax a strict pinning for numpy & cmake Update run command for conda build on Win Fix declaring DPLROOT env Fix DPLROOT source Fix DPLROOT for Win Add missing double quotes Try conda-incubator for Linux Setup conda-incubator for Linux Update caching Exclude python 3.8 Strickly pin on 3.8.13 Change channel order Fix artifcat uploading Replace to single quotes Add missing backslash Corect backslash
Add git workflow factions or Windows
attempt to fix upload steps of the workflow on Linux
…ict numpy version bracket for host section
Build for numpy 1.21
* Reorder channels in conda-build * Remove conda-build script for Linux
* [SAT-5366] setuptools 63.4.1 breaks build for Windows * Add TODO note as suggested in review comment
Add extra information on how to build dpnp from source.
* Fix import dpnp on Win & python 3.10 * PATH is used by python till 3.10 * Update dpnp/__init__.py Co-authored-by: Oleksandr Pavlyk <[email protected]> * Update dpnp/__init__.py Co-authored-by: Oleksandr Pavlyk <[email protected]> * Update dpnp/__init__.py Co-authored-by: Oleksandr Pavlyk <[email protected]> * Update dpnp/__init__.py Co-authored-by: Oleksandr Pavlyk <[email protected]> * Apply review comments Co-authored-by: Oleksandr Pavlyk <[email protected]>
* Fix support of compute follows data in dpnp.erf * Include tests for dpnp.erf in validation with github action
* Fix github action for building docs * Get rid of pinning for cmake
* Align normalize_queue_device call with CFD in dpnp * Update dpnp/dpnp_iface.py Co-authored-by: Oleksandr Pavlyk <[email protected]> * Update dpnp/dpnp_iface.py Co-authored-by: Oleksandr Pavlyk <[email protected]> Co-authored-by: Oleksandr Pavlyk <[email protected]>
* update numpy restriction by adding numpy 1.22 * Update conda-recipe/meta.yaml Also exclude alpha/beta builds of 1.23 sources Co-authored-by: Oleksandr Pavlyk <[email protected]>
* Get rid of env var stating dep on dpctl.tensor * Apply review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge latest changes from master for including them into nightly tests in CI.
The commit includes a fix of issue reporting in issue #1203