Skip to content

Commit e0bf731

Browse files
committed
modifying related tests suggested by reviewers
1 parent 6454b3e commit e0bf731

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

tests/test_mathematical.py

+6-9
Original file line numberDiff line numberDiff line change
@@ -615,11 +615,10 @@ def test_ceil(self, dtype):
615615
assert_array_equal(expected, result)
616616

617617
@pytest.mark.parametrize(
618-
"dtype", get_all_dtypes(no_bool=True, no_complex=True, no_none=True)
618+
"dtype", get_all_dtypes(no_complex=True, no_none=True)[:-1]
619619
)
620620
def test_invalid_dtype(self, dtype):
621-
dpnp_dtype = dpnp.float64 if has_support_aspect64() else dpnp.float32
622-
pytest.skip("similar data types") if dpnp_dtype == dtype else None
621+
dpnp_dtype = get_all_dtypes(no_complex=True, no_none=True)[-1]
623622
dp_array = dpnp.arange(10, dtype=dpnp_dtype)
624623
dp_out = dpnp.empty(10, dtype=dtype)
625624

@@ -656,11 +655,10 @@ def test_floor(self, dtype):
656655
assert_array_equal(expected, result)
657656

658657
@pytest.mark.parametrize(
659-
"dtype", get_all_dtypes(no_bool=True, no_complex=True, no_none=True)
658+
"dtype", get_all_dtypes(no_complex=True, no_none=True)[:-1]
660659
)
661660
def test_invalid_dtype(self, dtype):
662-
dpnp_dtype = dpnp.float64 if has_support_aspect64() else dpnp.float32
663-
pytest.skip("similar data types") if dpnp_dtype == dtype else None
661+
dpnp_dtype = get_all_dtypes(no_complex=True, no_none=True)[-1]
664662
dp_array = dpnp.arange(10, dtype=dpnp_dtype)
665663
dp_out = dpnp.empty(10, dtype=dtype)
666664

@@ -697,11 +695,10 @@ def test_trunc(self, dtype):
697695
assert_array_equal(expected, result)
698696

699697
@pytest.mark.parametrize(
700-
"dtype", get_all_dtypes(no_bool=True, no_complex=True, no_none=True)
698+
"dtype", get_all_dtypes(no_complex=True, no_none=True)[:-1]
701699
)
702700
def test_invalid_dtype(self, dtype):
703-
dpnp_dtype = dpnp.float64 if has_support_aspect64() else dpnp.float32
704-
pytest.skip("similar data types") if dpnp_dtype == dtype else None
701+
dpnp_dtype = get_all_dtypes(no_complex=True, no_none=True)[-1]
705702
dp_array = dpnp.arange(10, dtype=dpnp_dtype)
706703
dp_out = dpnp.empty(10, dtype=dtype)
707704

0 commit comments

Comments
 (0)