Skip to content

Commit 7bddfbe

Browse files
authored
Remove temporary solution accepting CFD with equal SYCL context instead of queue (#1303)
1 parent d22214c commit 7bddfbe

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

dpnp/dpnp_utils/dpnp_algo_utils.pyx

-3
Original file line numberDiff line numberDiff line change
@@ -651,9 +651,6 @@ cdef tuple get_common_usm_allocation(dpnp_descriptor x1, dpnp_descriptor x2):
651651
"".format(array1_obj.usm_type, array2_obj.usm_type))
652652

653653
common_sycl_queue = dpu.get_execution_queue((array1_obj.sycl_queue, array2_obj.sycl_queue))
654-
# TODO: refactor, remove when CFD is implemented in all array constructors
655-
if common_sycl_queue is None and array1_obj.sycl_context == array2_obj.sycl_context:
656-
common_sycl_queue = array1_obj.sycl_queue
657654
if common_sycl_queue is None:
658655
raise ValueError(
659656
"could not recognize common SYCL queue for inputs in SYCL queues {} and {}"

tests/test_sycl_queue.py

+15-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
import numpy
77

88
from numpy.testing import (
9-
assert_array_equal
9+
assert_array_equal,
10+
assert_raises
1011
)
1112

1213

@@ -353,6 +354,19 @@ def test_broadcasting(func, data1, data2, device):
353354
assert_sycl_queue_equal(result_queue, expected_queue)
354355

355356

357+
@pytest.mark.parametrize("func", ["add", "copysign", "divide", "floor_divide", "fmod",
358+
"maximum", "minimum", "multiply", "outer", "power",
359+
"remainder", "subtract"])
360+
@pytest.mark.parametrize("device",
361+
valid_devices,
362+
ids=[device.filter_string for device in valid_devices])
363+
def test_2in_1out_diff_queue_but_equal_context(func, device):
364+
x1 = dpnp.arange(10)
365+
x2 = dpnp.arange(10, sycl_queue=dpctl.SyclQueue(device))[::-1]
366+
with assert_raises(ValueError):
367+
getattr(dpnp, func)(x1, x2)
368+
369+
356370
@pytest.mark.parametrize(
357371
"func, kwargs",
358372
[

0 commit comments

Comments
 (0)