Skip to content

Commit 53d50d5

Browse files
committed
Applied review comments
1 parent 2420ede commit 53d50d5

File tree

7 files changed

+34
-11
lines changed

7 files changed

+34
-11
lines changed

.github/workflows/build-sphinx.yml

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ jobs:
122122
github_token: ${{ secrets.GITHUB_TOKEN }}
123123
publish_dir: ${{ env.PUBLISH_DIR }}
124124

125-
- name: Deploy docs [PR]
125+
- name: Publish pull-request docs
126126
if: |
127127
!github.event.pull_request.head.repo.fork && github.event.pull_request && github.event.action != 'closed'
128128
uses: peaceiris/[email protected]
@@ -136,6 +136,17 @@ jobs:
136136
user_name: 'github-actions[bot]'
137137
user_email: 'github-actions[bot]@users.noreply.github.com'
138138

139+
- name: Comment with URL to published pull-request docs
140+
if: |
141+
!github.event.pull_request.head.repo.fork && github.event.pull_request && github.event.action != 'closed'
142+
env:
143+
PR_NUM: ${{ github.event.number }}
144+
uses: mshick/[email protected]
145+
with:
146+
message: |
147+
View rendered docs @ https://intelpython.github.io/dpnp/pulls/${{ env.PR_NUM }}/index.html
148+
allow-repeats: false
149+
139150
clean:
140151
if: |
141152
!github.event.pull_request.head.repo.fork && github.event.pull_request && github.event.action == 'closed'
@@ -162,3 +173,11 @@ jobs:
162173
git config --global user.email 'github-actions[bot]@users.noreply.github.com'
163174
git commit -m "Removing docs for closed pull request ${PR_NUM}"
164175
git push tokened_docs gh-pages
176+
177+
- name: Modify the comment with URL to official documentation
178+
uses: mshick/[email protected]
179+
with:
180+
find: |
181+
View rendered docs @.+
182+
replace: |
183+
View rendered docs @ https://intelpython.github.io/dpnp/index.html

doc/dpnp_backend_api.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
C++ backend API Reference
55
*************************
66

7-
`DPNP C++ backend <backend_doc/>`_
7+
`C++ backend of Data Parallel Extension for NumPy* <backend_doc/>`_

doc/overview.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ functions and numerical data types.
1414
The Data Parallel Extension for NumPy* is being developed as part of
1515
`Intel AI Analytics Toolkit`_ and is distributed with the
1616
`Intel Distribution for Python*`_. The dpnp package is also available
17-
on Anaconda cloud. Please refer the :doc:`getting_started` page to learn more.
17+
on Anaconda cloud. Please refer the :doc:`quick_start_guide` page to learn more.
1818

1919
Being drop-in replacement for `NumPy*`_ means that the usage is very similar:
2020

doc/quick_start_guide.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ Install Package from Anaconda
4343
It is recommended to use conda packages from the ``anaconda.org/intel``
4444
channel. You will need one of the commands below:
4545

46-
* Conda: ``conda install dpnp``
46+
* Conda: ``conda install dpnp -c intel -c conda-forge``
4747

48-
* Pip: ``pip install dpnp``
48+
* Pip: ``pip install -i https://pypi.anaconda.org/intel/simple dpnp``
4949

5050
These commands install dpnp package along with its dependencies, including
5151
``dpctl`` package with `Data Parallel Control Library`_ and all required

doc/reference/difference.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
Difference between DPNP and NumPy
2-
=================================
1+
Difference with NumPy*
2+
======================
33

44
.. _Data types:
55

dpnp/backend/doc/Doxyfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ PROJECT_NUMBER = 0.12.1
4444
# for a project that appears at the top of each page and should give viewer a
4545
# quick idea about the purpose of the project. Keep the description short.
4646

47-
PROJECT_BRIEF = "NumPy-like API accelerated with SYCL"
47+
PROJECT_BRIEF = "Data Parallel Extension for NumPy*"
4848

4949
# With the PROJECT_LOGO tag one can specify a logo or an icon that is included
5050
# in the documentation. The maximum height of the logo should not exceed 55

dpnp/dpnp_iface.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -334,11 +334,15 @@ def get_dpnp_descriptor(
334334

335335

336336
def get_include():
337-
r"""Return the directory that contains the DPNP C++ backend \*.h header files."""
337+
r"""
338+
Return the directory that contains \*.h header files of dpnp C++ backend.
338339
339-
dpnp_path = os.path.join(os.path.dirname(__file__), "backend", "include")
340+
An extension module that needs to be compiled against dpnp backend
341+
should use this function to locate the appropriate include directory.
340342
341-
return dpnp_path
343+
"""
344+
345+
return os.path.join(os.path.dirname(__file__), "backend", "include")
342346

343347

344348
def get_normalized_queue_device(obj=None, device=None, sycl_queue=None):

0 commit comments

Comments
 (0)