-
Notifications
You must be signed in to change notification settings - Fork 29
Add support for raw_kernel_arg extension #2038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
libsyclinterface/include/syclinterface/dpctl_sycl_extension_interface.h
Outdated
Show resolved
Hide resolved
@sommerlukas |
1ea6b9c
to
296e236
Compare
libsyclinterface/include/syclinterface/dpctl_sycl_extension_interface.h
Outdated
Show resolved
Hide resolved
libsyclinterface/include/syclinterface/dpctl_sycl_extension_interface.h
Outdated
Show resolved
Hide resolved
Switch approach to not introduce an intermediate struct, but have the opaque pointer directly point to std::vector instead.
Thanks for the feedback @ndgrigorian @AlexanderKalistratov! After taking a look at how the opaque pointers for other |
ba642e9
to
a0b4c75
Compare
@ndgrigorian @AlexanderKalistratov Friendly ping for reviews. CI is looking quite good now, I can unfortunately not see the logs for the single failing Jenkins job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sommerlukas PR looks great for me, thank you!
I'm not code owner, so we need to wait @ndgrigorian review as well
Sorry, forgot to put my final review on this. Jenkins job is unrelated. I'll give it a last look over but I think it's ready to go in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add support for the DPC++ SYCL extension
raw_kernel_arg
that allows to pass a binary blob as kernel arguments.This is for example useful if the kernel uses a
struct
as kernel parameter, but is loaded from SPIR-V and the argument type is unknown forset_arg
.The implementation follows #1984.