Skip to content

Add intel device info data #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 9, 2023
Merged

Add intel device info data #1428

merged 7 commits into from
Oct 9, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Oct 4, 2023 •
edited
Loading

This PR exposes device descriptors from https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md

It adds dpctl.utils.intel_device_info(dev) function that returns dictionary with meaningful values for these descriptors (if implemented).

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1428/index.html

@coveralls
Copy link
Collaborator

coveralls commented Oct 4, 2023 •
edited
Loading

Coverage Status

coverage: 85.68% (-0.2%) from 85.909% when pulling cd0ec5d on add-intel-device-info-data into ebf118a on master.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_6 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_7 ran successfully.
Passed: 934
Failed: 66
Skipped: 119

ndgrigorian
ndgrigorian previously approved these changes Oct 5, 2023
View reviewed changes
@oleksandr-pavlyk
Added a comment line
049cd77
@oleksandr-pavlyk
Implement Python API for ext_intel_device_info descriptors
f73a1c4 
https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md

This includes HW characteristics for Intel Level-Zero GPU devices as well as
access to PCI device-identifier.
@oleksandr-pavlyk
Add tests for new function in dpctl.utils
d11e64e 
Adds a test for _is_gen9 helper utility useful for skipping
tests known to fail on Gen9.

Adds a test for intel_device_info function.
Test that descriptor names do not have typos.
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the add-intel-device-info-data branch from c33855d to d11e64e Compare October 6, 2023 01:51
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_8 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_10 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_13 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the add-intel-device-info-data branch from bb6db13 to 21f1cca Compare October 6, 2023 23:43
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_13 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the add-intel-device-info-data branch from 21f1cca to cd0ec5d Compare October 7, 2023 03:26
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_13 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk merged commit 08cc479 into master Oct 9, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the add-intel-device-info-data branch October 9, 2023 21:24
@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Jan 26, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian