Use sycl ext oneapi experimental for complex #1411

oleksandr-pavlyk · 2023-09-20T21:30:32Z

This PR applies functions from sycl::ext:;oneapi::experimental extension to evaluate trigonometric, hyperbolic unary functions and their inverses.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you opening the PR as a draft?

github-actions · 2023-09-20T22:01:47Z

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1411/index.html

coveralls · 2023-09-20T22:11:32Z

coverage: 85.942%. remained the same
when pulling 0efe28b on use-sycl-ext-oneapi-experimental-for-complex
into f772888 on master.

github-actions · 2023-09-20T22:47:35Z

Array API standard conformance tests for dpctl=0.15.0rc1=py310ha25a700_5 ran successfully.
Passed: 915
Failed: 85
Skipped: 119

github-actions · 2023-09-22T17:54:57Z

Array API standard conformance tests for dpctl=0.15.0rc2=py310ha25a700_3 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

github-actions · 2023-09-27T16:23:55Z

Array API standard conformance tests for dpctl=0.15.0rc3=py310ha25a700_5 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

github-actions · 2023-09-27T23:03:47Z

Array API standard conformance tests for dpctl=0.15.0=py310ha25a700_6 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

github-actions · 2023-09-29T21:10:15Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_9 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

github-actions · 2023-10-06T18:23:36Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_14 ran successfully.
Passed: 934
Failed: 66
Skipped: 119

github-actions · 2023-10-11T18:00:04Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_40 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

github-actions · 2023-10-14T21:53:15Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_51 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

ndgrigorian · 2023-10-25T02:24:01Z

@oleksandr-pavlyk
I've spotted a few cases where std functions are still used on complex values.

std::log

dpctl/dpctl/tensor/libtensor/include/kernels/elementwise_functions/acos.hpp

Line 108 in 71b85ab

argT log_in = std::log(in);

dpctl/dpctl/tensor/libtensor/include/kernels/elementwise_functions/acosh.hpp

Line 115 in 71b85ab

const realT wx = std::real(std::log(in));

dpctl/dpctl/tensor/libtensor/include/kernels/elementwise_functions/asin.hpp

Line 125 in 71b85ab

auto log_z = std::log(z);

dpctl/dpctl/tensor/libtensor/include/kernels/elementwise_functions/asinh.hpp

Line 111 in 71b85ab

resT log_in = (std::signbit(x)) ? std::log(-in) : std::log(in);

std::sinh

dpctl/dpctl/tensor/libtensor/include/kernels/elementwise_functions/sinh.hpp

Line 84 in 71b85ab

return std::sinh(in);

github-actions · 2023-10-27T00:24:51Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_83 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

github-actions · 2023-10-27T02:39:31Z

Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_90 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

github-actions · 2023-11-05T23:51:42Z

Array API standard conformance tests for dpctl=0.15.1dev1=py310ha25a700_2 ran successfully.
Passed: 935
Failed: 65
Skipped: 119

github-actions · 2023-11-09T04:24:59Z

Array API standard conformance tests for dpctl=0.15.1dev1=py310ha25a700_14 ran successfully.
Passed: 1021
Failed: 51
Skipped: 50

This works around use of double precision functions/literals in implementations of these functions in MSVC headers, causing failures to offload on Iris Xe for single precision input citing lack of fp64 support by the hardware. Changes include CL/sycl.hpp to sycl/sycl.hpp per SYCL-2020 spec For every CMake target, where add_sycl_to_target is used, we also run target_compile_options( ${target_name} PRIVATE -fysl-targets=spir64-unknown-unknown,nvptx64-nvidia-cuda ) Add DPCTL_TARGET_CUDA Boolean cmake option Also DPCTL_SYCL_TARGETS parameter can be used to specify targets to build for. DPCTL_TARGET_CUDA could be set via cmake option, or via environment variable, e.g. ``` $ DPCTL_TARGET_CUDA=1 python scripts/build_locally.py --verbose ``` This calls `target_compile_options` to set sycl-targets for targets needing SYCL

github-actions · 2023-11-16T22:36:51Z

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_13 ran successfully.
Passed: 1019
Failed: 55
Skipped: 59

github-actions · 2023-11-16T23:43:25Z

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_14 ran successfully.
Passed: 1019
Failed: 55
Skipped: 59

oleksandr-pavlyk · 2023-11-17T01:18:47Z

@ndgrigorian ready to merge, please take a look

github-actions · 2023-11-18T16:00:57Z

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_14 ran successfully.
Passed: 1020
Failed: 54
Skipped: 59

dpctl/tensor/libtensor/include/kernels/elementwise_functions/sqrt.hpp

Introduced private header to load SYCL's experimental complex header from the right location. The header and implementations respond to USE_SYCL_FOR_COMPLEX_TYPES preprocessor variable. If set, sycl::ext::oneapi::experimental namespace functions are to be used. Otherwise std:: namespace functions will be used instead for complex types. USE_SYCL_FOR_COMPLEX_TYPES is being set in tensor/CMakeLists.txt If USE_SYCL_FOR_COMPLEX_TYPES is not set, std:: functions are used except for sqrt and abs functions. For abs we use hypot(std::real(z), std::imag(z)) and for sqrt we use custom implementation on Windows to avoid failure to offload for single precision type due to unwarranted use of double precision types in the implementation for single precision inputs iin MS VC headers

…orms

github-actions · 2023-11-20T14:10:45Z

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_14 ran successfully.
Passed: 1018
Failed: 56
Skipped: 59

dpctl/tensor/CMakeLists.txt

dpctl/tensor/libtensor/include/kernels/elementwise_functions/isfinite.hpp

ndgrigorian

LGTM, thank you @oleksandr-pavlyk ! Nice to see the internal CI passing again.

github-actions · 2023-11-20T18:56:41Z

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_15 ran successfully.
Passed: 1020
Failed: 54
Skipped: 59

github-actions · 2023-11-20T19:00:35Z

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_16 ran successfully.
Passed: 1018
Failed: 56
Skipped: 59

After transition to oneapi::experimental namespace functions for complex types in gh-1411, all tests pass.

oleksandr-pavlyk force-pushed the use-sycl-ext-oneapi-experimental-for-complex branch from 02fa4de to 8a5788c Compare September 22, 2023 16:36

oleksandr-pavlyk force-pushed the use-sycl-ext-oneapi-experimental-for-complex branch from 8a5788c to 3339d48 Compare September 27, 2023 15:21

oleksandr-pavlyk force-pushed the use-sycl-ext-oneapi-experimental-for-complex branch from 3339d48 to 468110d Compare September 27, 2023 21:48

oleksandr-pavlyk force-pushed the use-sycl-ext-oneapi-experimental-for-complex branch from 468110d to 7c4b0ca Compare September 29, 2023 19:48

oleksandr-pavlyk force-pushed the use-sycl-ext-oneapi-experimental-for-complex branch from 7c4b0ca to 74b3b53 Compare October 6, 2023 16:49

oleksandr-pavlyk force-pushed the use-sycl-ext-oneapi-experimental-for-complex branch from 74b3b53 to 6d7d3fe Compare October 11, 2023 16:51

oleksandr-pavlyk force-pushed the use-sycl-ext-oneapi-experimental-for-complex branch from 6d7d3fe to 71b85ab Compare October 14, 2023 20:24

oleksandr-pavlyk force-pushed the use-sycl-ext-oneapi-experimental-for-complex branch from 479a969 to 8555f7d Compare October 26, 2023 22:47

oleksandr-pavlyk force-pushed the use-sycl-ext-oneapi-experimental-for-complex branch from 8555f7d to 49d12ec Compare October 27, 2023 00:57

oleksandr-pavlyk force-pushed the use-sycl-ext-oneapi-experimental-for-complex branch from 49d12ec to c90c261 Compare November 5, 2023 22:29

oleksandr-pavlyk force-pushed the use-sycl-ext-oneapi-experimental-for-complex branch from c90c261 to affc054 Compare November 9, 2023 02:40

oleksandr-pavlyk force-pushed the use-sycl-ext-oneapi-experimental-for-complex branch from affc054 to 6d3be5d Compare November 16, 2023 21:36

oleksandr-pavlyk marked this pull request as ready for review November 17, 2023 03:20

oleksandr-pavlyk force-pushed the use-sycl-ext-oneapi-experimental-for-complex branch from ac42985 to 0f76890 Compare November 18, 2023 15:06

ndgrigorian reviewed Nov 20, 2023

View reviewed changes

dpctl/tensor/libtensor/include/kernels/elementwise_functions/sqrt.hpp Show resolved Hide resolved

oleksandr-pavlyk force-pushed the use-sycl-ext-oneapi-experimental-for-complex branch from 0f76890 to c77344c Compare November 20, 2023 13:07

oleksandr-pavlyk added 2 commits November 20, 2023 07:11

Streamlined cmake script, set USE_SYCL_FOR_COMPLEX_TYPES on all platf…

8405af7

…orms

Removed superflous namespace creation line

0efe28b

oleksandr-pavlyk requested a review from ndgrigorian November 20, 2023 17:37

ndgrigorian reviewed Nov 20, 2023

View reviewed changes

dpctl/tensor/CMakeLists.txt Outdated Show resolved Hide resolved

ndgrigorian reviewed Nov 20, 2023

View reviewed changes

dpctl/tensor/libtensor/include/kernels/elementwise_functions/isfinite.hpp Outdated Show resolved Hide resolved

ndgrigorian approved these changes Nov 20, 2023

View reviewed changes

oleksandr-pavlyk merged commit 5ec9fd5 into master Nov 20, 2023

oleksandr-pavlyk deleted the use-sycl-ext-oneapi-experimental-for-complex branch November 20, 2023 20:52

ndgrigorian mentioned this pull request Nov 23, 2023

dpt.pow() with dtype=c16 and scalar on gpu/cpu returns different result #1378

Closed

oleksandr-pavlyk added a commit that referenced this pull request Nov 24, 2023

Remove marks broken_complex from all tests

14ee859

After transition to oneapi::experimental namespace functions for complex types in gh-1411, all tests pass.

oleksandr-pavlyk mentioned this pull request Nov 24, 2023

Remove marks broken_complex from all tests #1475

Merged

6 tasks

oleksandr-pavlyk added a commit that referenced this pull request Dec 5, 2023

Remove marks broken_complex from all tests

2b45633

After transition to oneapi::experimental namespace functions for complex types in gh-1411, all tests pass.

oleksandr-pavlyk added a commit that referenced this pull request Dec 9, 2023

Remove marks broken_complex from all tests

afd60d1

After transition to oneapi::experimental namespace functions for complex types in gh-1411, all tests pass.

oleksandr-pavlyk added a commit that referenced this pull request Dec 11, 2023

Remove marks broken_complex from all tests

54891ee

After transition to oneapi::experimental namespace functions for complex types in gh-1411, all tests pass.

oleksandr-pavlyk added a commit that referenced this pull request Dec 12, 2023

Remove marks broken_complex from all tests

3828d86

After transition to oneapi::experimental namespace functions for complex types in gh-1411, all tests pass.

oleksandr-pavlyk mentioned this pull request Jan 26, 2024

Populated changelog of new features since 0.15.0 release #1510

Merged

6 tasks

Use sycl ext oneapi experimental for complex #1411

Use sycl ext oneapi experimental for complex #1411

Uh oh!

Conversation

oleksandr-pavlyk commented Sep 20, 2023

Uh oh!

github-actions bot commented Sep 20, 2023

Uh oh!

coveralls commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 20, 2023

Uh oh!

github-actions bot commented Sep 22, 2023

Uh oh!

github-actions bot commented Sep 27, 2023

Uh oh!

github-actions bot commented Sep 27, 2023

Uh oh!

github-actions bot commented Sep 29, 2023

Uh oh!

github-actions bot commented Oct 6, 2023

Uh oh!

github-actions bot commented Oct 11, 2023

Uh oh!

github-actions bot commented Oct 14, 2023

Uh oh!

ndgrigorian commented Oct 25, 2023

Uh oh!

github-actions bot commented Oct 27, 2023

Uh oh!

github-actions bot commented Oct 27, 2023

Uh oh!

github-actions bot commented Nov 5, 2023

Uh oh!

github-actions bot commented Nov 9, 2023

Uh oh!

github-actions bot commented Nov 16, 2023

Uh oh!

github-actions bot commented Nov 16, 2023

Uh oh!

oleksandr-pavlyk commented Nov 17, 2023

Uh oh!

github-actions bot commented Nov 18, 2023

Uh oh!

Uh oh!

github-actions bot commented Nov 20, 2023

Uh oh!

Uh oh!

Uh oh!

ndgrigorian left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 20, 2023

Uh oh!

github-actions bot commented Nov 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coveralls commented Sep 20, 2023 •

edited

Loading