Skip to content

Fix boolean reductions for #1327 #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Fix boolean reductions for #1327 #1329

merged 2 commits into from
Aug 8, 2023

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Aug 8, 2023

Closes #1327

This PR fixes a typo in the Python binding common to both boolean reductions (any, all).

The binding was calling the implementations of these functions with dst_nd rather than iter_nd.

dst_nd and iter_nd often ended up being the same for small-dimensional arrays, which masked the problem.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 84.839%. remained the same when pulling 7e2a434 on fix-gh-1327 into a1dd350 on master.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_93 ran successfully.
Passed: 639
Failed: 361
Skipped: 119

@ndgrigorian ndgrigorian merged commit acd1a60 into master Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_91 ran successfully.
Passed: 639
Failed: 361
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-gh-1327 branch August 9, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of dpctl.tensor.all and dpctl.tensor.any with axis=0 parameter
3 participants