Return events for comp. tasks, rather than temp-clean up host tasks #1176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tasks
This resolves a hang that Anton has uncovered. The gist of the bug is
```
for i in range(op_count):
v[i] = dpt.empty_like(a[i], order='F', dtype=v_type)
ht_copy_ev[i], copy_ev = ti._copy_usm_ndarray_into_usm_ndarray(src=a[i], dst=v[i], sycl_queue=a_sycl_queue)
di._wait(copy_ev)
```
Here is `di` is a Pybind11 extensions, whose function `_wait` was implemented as
```
m.def("_wait", [](sycl::event e) -> void { e.wait(); }, "");
```
The script would hang on the second iteration of the loop if `di._wait` call.
The hang disappears after the change in this commit. Out attempts to build a C++ reproducer
have not been successful thus far.
oleksandr-pavlyk
force-pushed
the
revert-returning-host-tasks
branch
from
57ba8e2 to
80f0463
Compare
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1176/index.html |
|
A reproducer for a hang fixed by this PR was filed as JIRA CMPLRLLVM-46895. |
ndgrigorian
approved these changes
Apr 18, 2023
|
Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_115 ran successfully. |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_117 ran successfully. |
|
Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_0 ran successfully. |
vtavana
pushed a commit
that referenced
this pull request
Apr 24, 2023
Return events for comp. tasks, rather than temp-clean up host tasks
vtavana
pushed a commit
that referenced
this pull request
Apr 24, 2023
Return events for comp. tasks, rather than temp-clean up host tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return events for computational tasks, rather than temp-clean up host tasks
This resolves a hang that Anton has uncovered. The gist of the bug is
Here is
diis a Pybind11 extensions, whose function_waitwas implemented asThe script would hang on the second iteration of the loop if
di._waitcall. The hang disappears after the change in this commit. Out attempts to build a C++ reproducer have not been successful thus far.