Skip to content

Fix implementation of dpctl.tensor.moveaxis() #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2023
Merged

Fix implementation of dpctl.tensor.moveaxis() #1174

merged 1 commit into from
Apr 18, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 18, 2023 •
edited
Loading

closes #1173
Fixes an error related to dpt.moveaxis and adds new tests from numpy

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@vtavana vtavana force-pushed the fix_moveaxis_error branch 2 times, most recently from 647ca26 to 40ace8f Compare April 18, 2023 04:29
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_115 ran successfully.
Passed: 47
Failed: 787
Skipped: 282

@coveralls
Copy link
Collaborator

coveralls commented Apr 18, 2023 •
edited
Loading

Coverage Status

Coverage: 83.263% (+0.009%) from 83.254% when pulling 15e5e73 on fix_moveaxis_error into b050e8c on master.

@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1174/index.html

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_115 ran successfully.
Passed: 47
Failed: 787
Skipped: 282

1 similar comment
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_115 ran successfully.
Passed: 47
Failed: 787
Skipped: 282

@vtavana vtavana changed the title fix an error for moveaxis Fix implementation of dpctl.tensor.moveaxis() Apr 18, 2023
@vtavana vtavana force-pushed the fix_moveaxis_error branch from 40ace8f to 15e5e73 Compare April 18, 2023 15:38
@vtavana vtavana self-assigned this Apr 18, 2023
oleksandr-pavlyk
oleksandr-pavlyk approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now the complexity is quadratic in the size of destination tuple, but luckily this size is bounded for meaningful applications.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 193a8b1 into master Apr 18, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix_moveaxis_error branch April 18, 2023 21:36
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_115 ran successfully.
Passed: 47
Failed: 787
Skipped: 282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dpctl.tensor.moveaxis does not work correctly
3 participants
@vtavana @coveralls @oleksandr-pavlyk