Skip to content

test: add tests for navigator observer #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2024
Merged

test: add tests for navigator observer #501

merged 3 commits into from
Aug 12, 2024

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Aug 11, 2024

Description of the change

Add tests for the InstabugNavigatorObserver class.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-15531

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Aug 11, 2024
@InstabugCI
Copy link
Collaborator

InstabugCI commented Aug 11, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
Dart 84.3% ✅

Generated by 🚫 dangerJS against 2f30d19

AndrewAminInstabug
AndrewAminInstabug approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@AndrewAminInstabug AndrewAminInstabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was a nice idea to use fake_async package 👏🏻

@ahmedAlaaInstabug
Copy link
Contributor

it's a great idea to use the fake_async package

@a7medev a7medev merged commit 9eac08d into dev Aug 12, 2024
11 checks passed
@a7medev a7medev deleted the test/navigator-observer branch August 12, 2024 11:19
ahmedAlaaInstabug pushed a commit that referenced this pull request Nov 4, 2024
@a7medev @ahmedAlaaInstabug
test: add tests for navigator observer (#501)
9a911a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedAlaaInstabug ahmedAlaaInstabug ahmedAlaaInstabug approved these changes

@AndrewAminInstabug AndrewAminInstabug AndrewAminInstabug approved these changes

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a7medev @InstabugCI @ahmedAlaaInstabug @AndrewAminInstabug