@rubyboy Sure, we'll see how things go.

I've checked how it's going in Angular Material, and it looks like it still isn't ready for Universal, see angular/components#308, but there's supposed to be a separate entry point for server side, like angular2-materialize/server import. Makes sense.

The good thing is that in Materialize most visuals are implemented with CSS, while JS does interaction with user. Until JS part will be rewritten to native Angular DOM manipulation like @MarkPieszak suggested, I guess that stubbing materialize directive and ignoring window stuff for server side is the only reasonable way.

Another direction I see is that browser part (angular2-materialize import) has to be refactored a bit to make it more suitable for server side if a user wants to render it with jsdom or something (not even sure if jsdom can handle jQuery and Waves and other complex DOM stuff). Currently mocking global.window will result in incorrect framework behaviour, angular/angular#16545 . Since there's no built-in window service, I guess it makes sense to introduce something like MATERIALIZE_WINDOW provider that defaults to window global and can be easily substituted with jsdom. I guess in this case window.document from MATERIALIZE_WINDOW should be preferred over built-in DOCUMENT provider, too, since implementations will be different on server side.

What do you think?

add support for angular2-universal #140

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions