Enable StrictMode in Dev App

Author: Ian Bird

dev-app/src/main/java/com/uid2/dev/DevApplication.kt

@@ -1,6 +1,7 @@
 package com.uid2.dev
 
 import android.app.Application
+import android.os.StrictMode
 import com.uid2.UID2Manager
 
 class DevApplication : Application() {
@@ -13,5 +14,20 @@ class DevApplication : Application() {
 
         // Alternatively, we could initialise the UID2Manager with our own custom NetworkSession...
         // UID2Manager.init(this.applicationContext, OkNetworkSession())
+
+        // For the development app, we will enable a strict thread policy to ensure we have suitable visibility of any
+        // issues within the SDK.
+        enableStrictMode()
+    }
+
+    private fun enableStrictMode() {
+        StrictMode.setThreadPolicy(
+            StrictMode.ThreadPolicy.Builder().apply {
+                detectDiskReads()
+                detectDiskWrites()
+                detectNetwork()
+                penaltyLog()
+            }.build(),
+        )
     }
 }

sdk/src/main/java/com/uid2/storage/FileStorageManager.kt

@@ -14,11 +14,14 @@ import java.io.File
  * An implementation of the StorageManager that persists UID2Identity instances in clear-text via a File.
  */
 internal class FileStorageManager(
-    private val identityFile: File,
+    val identityFileFactory: () -> File,
     private val ioDispatcher: CoroutineDispatcher = Dispatchers.IO,
 ) : StorageManager {
 
-    constructor(context: Context) : this(File(context.filesDir, FILE_IDENTITY))
+    constructor(context: Context) : this({ File(context.filesDir, FILE_IDENTITY) })
+
+    // This lazy value *should* only be requested on the ioDispatcher.
+    private val identityFile: File by lazy { identityFileFactory() }
 
     override suspend fun saveIdentity(identity: UID2Identity, status: IdentityStatus) = withContext(ioDispatcher) {
         runCatching {

sdk/src/test/java/com/uid2/storage/FileStorageManagerTest.kt

@@ -45,7 +45,7 @@ class FileStorageManagerTest {
             "refresh response key",
         )
 
-        val storageManager = FileStorageManager(identityFile, testDispatcher)
+        val storageManager = FileStorageManager({ identityFile }, testDispatcher)
         storageManager.saveIdentity(identity, ESTABLISHED)
         testDispatcher.scheduler.advanceUntilIdle()
 
@@ -65,7 +65,7 @@ class FileStorageManagerTest {
             "refresh response key",
         )
 
-        val storageManager = FileStorageManager(identityFile, testDispatcher)
+        val storageManager = FileStorageManager({ identityFile }, testDispatcher)
         storageManager.saveIdentity(identity, ESTABLISHED)
         testDispatcher.scheduler.advanceUntilIdle()