Skip to content

exercise #2 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

exercise #2 #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95514dd
done
RV8V Jan 3, 2020
b08404c
fix
RV8V Jan 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Exercises/1-seq.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
'use strict';

const seq = f => g => x => 0;
//const seq = f => g => x => 0;

const seq = f => g => (typeof g === 'number' ? f(g) : seq(x => f(g(x))));

module.exports = { seq };
3 changes: 2 additions & 1 deletion Exercises/2-array.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';

const array = () => null;
const array = (a = [], f) =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use arguments to declare local scope variables

(f = i => a[i], f.push = s => a.push(s), f.pop = () => a.pop(), f);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cryptic code. Rewrite as a block of code, for better reading. Because this function is not in function-programming style, it uses mixins and mutable arrays, so it is not good idea to write it in a functional-style.


module.exports = { array };
2 changes: 1 addition & 1 deletion Exercises/2-array.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
({
name: 'array',
length: [100, 200],
length: [80, 200],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change tests

test: array => {
{
const arr = array();
Expand Down