Labs done #8
Open
Labs done #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshemsedinov
reviewed
Dec 3, 2019
| @@ -1,7 +1,8 @@ | |||
| 'use strict'; | |||
|
|
|||
| const removeElement = (array, item) => { | |||
| // Remove item from array modifying original array | |||
| const index = array.indexOf(item); | |||
| return index !== -1 ? array.splice(index, 1) : array; | |||
There was a problem hiding this comment.
This task implies modifying original array, no need to return anything, but it's ok. Not ok is to use ternary here, if statement is more relevant for this case.
| @@ -1,7 +1,11 @@ | |||
| 'use strict'; | |||
|
|
|||
| const removeElements = (array, ...items) => { | |||
| // Remove multiple items from array modifying original array | |||
| for (const i of items) { | |||
There was a problem hiding this comment.
Naming i may confuse someone (may refer to i:Number like in regular for loops), better use item or element here.
| const index = array.indexOf(i); | ||
| if (index !== -1) array.splice(index, 1); | ||
| } | ||
| return array; |
There was a problem hiding this comment.
No need to return, but it's ok.
| const unique = array => []; | ||
| const unique = array => { | ||
| const arr = []; | ||
| for (const item of array) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.