Skip to content

Commit 3ee47f8

Browse files
authored
Revert "core/vm: order opcodes properly (ethereum#27113)"
This reverts commit bc7f528.
1 parent dc7777a commit 3ee47f8

File tree

1 file changed

+18
-20
lines changed

1 file changed

+18
-20
lines changed

core/vm/opcodes.go

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -204,12 +204,6 @@ const (
204204
LOG4
205205
)
206206

207-
// 0xb0 range.
208-
const (
209-
TLOAD OpCode = 0xb3
210-
TSTORE OpCode = 0xb4
211-
)
212-
213207
// 0xf0 range - closures.
214208
const (
215209
CREATE OpCode = 0xf0
@@ -225,6 +219,12 @@ const (
225219
SELFDESTRUCT OpCode = 0xff
226220
)
227221

222+
// 0xb0 range.
223+
const (
224+
TLOAD OpCode = 0xb3
225+
TSTORE OpCode = 0xb4
226+
)
227+
228228
// Since the opcodes aren't all in order we can't use a regular slice.
229229
var opCodeToString = map[OpCode]string{
230230
// 0x0 range - arithmetic ops.
@@ -290,7 +290,9 @@ var opCodeToString = map[OpCode]string{
290290
BASEFEE: "BASEFEE",
291291

292292
// 0x50 range - 'storage' and execution.
293-
POP: "POP",
293+
POP: "POP",
294+
//DUP: "DUP",
295+
//SWAP: "SWAP",
294296
MLOAD: "MLOAD",
295297
MSTORE: "MSTORE",
296298
MSTORE8: "MSTORE8",
@@ -304,7 +306,7 @@ var opCodeToString = map[OpCode]string{
304306
JUMPDEST: "JUMPDEST",
305307
PUSH0: "PUSH0",
306308

307-
// 0x60 range - pushes.
309+
// 0x60 range - push.
308310
PUSH1: "PUSH1",
309311
PUSH2: "PUSH2",
310312
PUSH3: "PUSH3",
@@ -338,7 +340,6 @@ var opCodeToString = map[OpCode]string{
338340
PUSH31: "PUSH31",
339341
PUSH32: "PUSH32",
340342

341-
// 0x80 - dups.
342343
DUP1: "DUP1",
343344
DUP2: "DUP2",
344345
DUP3: "DUP3",
@@ -356,7 +357,6 @@ var opCodeToString = map[OpCode]string{
356357
DUP15: "DUP15",
357358
DUP16: "DUP16",
358359

359-
// 0x90 - swaps.
360360
SWAP1: "SWAP1",
361361
SWAP2: "SWAP2",
362362
SWAP3: "SWAP3",
@@ -373,19 +373,17 @@ var opCodeToString = map[OpCode]string{
373373
SWAP14: "SWAP14",
374374
SWAP15: "SWAP15",
375375
SWAP16: "SWAP16",
376-
377-
// 0xa0 range - logging ops.
378-
LOG0: "LOG0",
379-
LOG1: "LOG1",
380-
LOG2: "LOG2",
381-
LOG3: "LOG3",
382-
LOG4: "LOG4",
376+
LOG0: "LOG0",
377+
LOG1: "LOG1",
378+
LOG2: "LOG2",
379+
LOG3: "LOG3",
380+
LOG4: "LOG4",
383381

384382
// 0xb0 range.
385383
TLOAD: "TLOAD",
386384
TSTORE: "TSTORE",
387385

388-
// 0xf0 range - closures.
386+
// 0xf0 range.
389387
CREATE: "CREATE",
390388
CALL: "CALL",
391389
RETURN: "RETURN",
@@ -475,6 +473,8 @@ var stringToOp = map[string]OpCode{
475473
"GAS": GAS,
476474
"JUMPDEST": JUMPDEST,
477475
"PUSH0": PUSH0,
476+
"TLOAD": TLOAD,
477+
"TSTORE": TSTORE,
478478
"PUSH1": PUSH1,
479479
"PUSH2": PUSH2,
480480
"PUSH3": PUSH3,
@@ -544,8 +544,6 @@ var stringToOp = map[string]OpCode{
544544
"LOG2": LOG2,
545545
"LOG3": LOG3,
546546
"LOG4": LOG4,
547-
"TLOAD": TLOAD,
548-
"TSTORE": TSTORE,
549547
"CREATE": CREATE,
550548
"CREATE2": CREATE2,
551549
"CALL": CALL,

0 commit comments

Comments
 (0)