Skip to content

Bezier length implementation #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 13, 2022
Merged

Bezier length implementation #676

merged 13 commits into from
Jun 13, 2022

Conversation

hannahli2010
Copy link
Contributor

Core changes

  • Implement the length function for a bezier segment
  • Add section for length in the interactive documentation and display the length value

Other changes:

  • Refactor WasmBezier to take lists of points
  • Add back eslint rule that was causing problems

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 11, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: abca6bc
Status: ✅  Deploy successful!
Preview URL: https://b53cd3cb.graphite-master.pages.dev
Branch Preview URL: https://bezier-length-impl.graphite-master.pages.dev

View logs

@hannahli2010 hannahli2010 marked this pull request as ready for review June 12, 2022 00:43
nupsi
nupsi reviewed Jun 12, 2022
View reviewed changes
0HyperCube
0HyperCube reviewed Jun 12, 2022
View reviewed changes
@hannahli2010 hannahli2010 requested a review from 0HyperCube June 12, 2022 20:21
0HyperCube
0HyperCube approved these changes Jun 12, 2022
View reviewed changes
Copy link
Member

@0HyperCube 0HyperCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The improved use of Vec2 has definitely made it easier to read - thanks for doing that.

@hannahli2010 hannahli2010 merged commit 94544ba into bezier-math-lib Jun 13, 2022
@hannahli2010 hannahli2010 deleted the bezier-length-impl branch June 13, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nupsi nupsi nupsi left review comments

@0HyperCube 0HyperCube 0HyperCube approved these changes

@Keavon Keavon Awaiting requested review from Keavon

@TrueDoctor TrueDoctor Awaiting requested review from TrueDoctor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hannahli2010 @Keavon @nupsi @0HyperCube @Androxium @RobNadal