Skip to content

Fix nudge and textbox creation #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2022
Merged

Fix nudge and textbox creation #672

merged 3 commits into from
Jun 10, 2022

Conversation

0HyperCube
Copy link
Member

@0HyperCube 0HyperCube commented Jun 9, 2022

Closes #669 and closes #660

@0HyperCube 0HyperCube linked an issue Jun 9, 2022 that may be closed by this pull request
@Keavon
Copy link
Member

Keavon commented Jun 9, 2022

Just a little note for future reference, GitHub doesn't parse the "and" in your PR message so it only recognizes the first bug number for the "Closes" command. You have to write out "closes" for each number. I wish they would fix this!

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 9, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4c85c6f
Status: ✅  Deploy successful!
Preview URL: https://e0471449.graphite-master.pages.dev
Branch Preview URL: https://fix-nudge.graphite-master.pages.dev

View logs

Copy link
Member

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good!

@Keavon Keavon merged commit 9a0afa3 into master Jun 10, 2022
@Keavon Keavon deleted the fix-nudge branch June 10, 2022 16:25
Keavon pushed a commit that referenced this pull request Jun 16, 2022
* Fix nudge and textbox creation

* Code review

* Cleanup veriable names
Keavon pushed a commit that referenced this pull request Jul 30, 2023
* Fix nudge and textbox creation

* Code review

* Cleanup veriable names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nudging layers isn't working Fix Interacting in GUI with text tool
3 participants