Refactor font loading from per-document to the portfolio #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
08a9847
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e66fcd7b.graphite-master.pages.dev |
Keavon
reviewed
May 22, 2022
Keavon
force-pushed
the
master
branch
2 times, most recently
from
a86fd02 to
fd95326
Compare
Keavon
changed the title
Keavon
added a commit
that referenced
this pull request
Jun 16, 2022
* Cleanup default font loading * Refactor fonts * Fix menulist mouse navigation * Format * Formatting * Move default font into consts.rs Co-authored-by: Keavon Chambers <[email protected]>
12 tasks
Keavon
added a commit
that referenced
this pull request
Jul 30, 2023
* Cleanup default font loading * Refactor fonts * Fix menulist mouse navigation * Format * Formatting * Move default font into consts.rs Co-authored-by: Keavon Chambers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #655
font_cacheper document -> font_cache in portfolio (involved passing thefont_cacheto all tools)TriggerFontLoadcalled from backend with default fonttool_data(primary/secondary colour) -> global_tool_datadata(for specific tool) -> tool_datatransitionby usingToolActionHandlerDataEqfor manyPartialEqstructs / enums)