feat(eventarc): new sample for storage event receiver #10222

muncus · 2023-06-12T21:00:33Z

Description

Create a new sample demonstrating receipt of Cloud Storage events with eventarc
and cloudevents.

Checklist

I have followed Sample Guidelines from AUTHORING_GUIDE.MD
README is updated to include all relevant information
Tests pass: nox -s py-3.9 (see Test Environment Setup)
Lint pass: nox -s lint (see Test Environment Setup)
These samples need a new API enabled in testing projects to pass (let us know which ones)
These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
Please merge this PR for me once it is approved

snippet-bot · 2023-06-13T16:16:49Z

Here is the summary of changes.

You are about to add 4 region tags.

eventarc/storage_handler/main.py:15, tag eventarc_storage_cloudevent_server
eventarc/storage_handler/main.py:29, tag eventarc_storage_cloudevent_handler
eventarc/storage_handler/main.py:52, tag eventarc_storage_cloudevent_server
eventarc/storage_handler/main_test.py:15, tag eventarc_testing_cloudevent

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

muncus · 2023-06-14T17:57:58Z

The owlbot post-processor failure is unrelated to this PR (underlying error is a formatting issue with an appengine file not touched in this change).

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

grayside

Thanks for creating this sample. There are a couple open points here as we align around the plan.

eventarc/storage_handler/main.py

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

grayside

LGTM with a couple more optional comments.

eventarc/storage_handler/main_test.py

grayside · 2023-06-26T18:33:58Z

eventarc/storage_handler/main.py

+
+    # Gets the GCS bucket name from the CloudEvent data
+    # Example: "storage.googleapis.com/projects/_/buckets/my-bucket"
+    storage_obj = StorageObjectData(event.data)


What happens if the data isn't formatted correctly? Is the error message at all useful? Will it crash?

I almost think we should validate the event source and type, but regardless we should make sure not to crash the service if a misconfigured event trigger is created.

This throws a ValueError if there's an invalid field (standard proto-plus behavior).
i've added a try/catch for this, so bad input will result in a 400, and added a test case.

muncus · 2023-06-27T18:37:13Z

Owlbot added formatting changes to DLP files to this PR for reasons I do not understand.
These DLP tests appear to have a resource conflict in them, making these tests flaky.

These tests compete for the same resource when there are multiple concurrent test runs. This leads to flaky tests as seen on #10222

* add unique string to dlp infotype tests These tests compete for the same resource when there are multiple concurrent test runs. This leads to flaky tests as seen on #10222 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

rsamborski · 2023-06-28T13:47:44Z

Owlbot added formatting changes to DLP files to this PR for reasons I do not understand.
These DLP tests appear to have a resource conflict in them, making these tests flaky.

@muncus feel free to revert owlbot changes. PR #10310 should protect against similar situations in the future, but just to be sure I've added an owlbot: ignore label.

muncus added 2 commits June 7, 2023 10:30

feat(eventarc): cloudevent GCS handler

998a495

Procfile, for easier cloud run deployment

892ba23

product-auto-label bot added api: eventarc Issues related to the Eventarc API. samples Issues that are directly related to samples. labels Jun 12, 2023

muncus added 4 commits June 12, 2023 14:19

lint cleanups

38b3e9d

lint errors from headers and imports

b2ed2a1

flake8 import order fix

902eec8

Merge branch 'main' into eventarc_storage_handler

8b67931

muncus marked this pull request as ready for review June 13, 2023 16:15

muncus requested review from a team as code owners June 13, 2023 16:15

muncus added 3 commits June 13, 2023 09:21

fix region tags

d46b8d4

really fix the region tag

c733d0d

Merge branch 'main' into eventarc_storage_handler

b4380ab

muncus added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 14, 2023

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 14, 2023

muncus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2023

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2023

kweinmeister and others added 2 commits June 15, 2023 11:26

Merge branch 'main' into eventarc_storage_handler

7ea1a5e

🦉 Updates from OwlBot post-processor

51269dd

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

grayside requested changes Jun 15, 2023

View reviewed changes

eventarc/storage_handler/main.py Show resolved Hide resolved

eventarc/storage_handler/main.py Outdated Show resolved Hide resolved

muncus marked this pull request as draft June 15, 2023 23:04

Merge branch 'main' into eventarc_storage_handler

3777531

muncus marked this pull request as ready for review June 20, 2023 22:06

muncus requested a review from grayside June 21, 2023 17:45

muncus and others added 2 commits June 21, 2023 10:45

Merge branch 'main' into eventarc_storage_handler

289c1c3

🦉 Updates from OwlBot post-processor

8877626

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

gcf-owl-bot bot requested a review from a team as a code owner June 21, 2023 17:48

Merge branch 'main' into eventarc_storage_handler

1eb3361

grayside approved these changes Jun 26, 2023

View reviewed changes

improve error handling, tests, per @grayside.

9c76c73

muncus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2023

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2023

muncus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2023

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 27, 2023

grayside approved these changes Jun 27, 2023

View reviewed changes

muncus added a commit that referenced this pull request Jun 27, 2023

add unique string to dlp infotype tests

166512b

These tests compete for the same resource when there are multiple concurrent test runs. This leads to flaky tests as seen on #10222

muncus mentioned this pull request Jun 27, 2023

fix(dlp, testing): add unique string to dlp infotype tests #10327

Merged

9 tasks

rsamborski added the owlbot:ignore instruct owl-bot to ignore a PR label Jun 28, 2023

rsamborski approved these changes Jun 28, 2023

View reviewed changes

Merge branch 'main' into eventarc_storage_handler

d7d1f4f

muncus merged commit 4687063 into main Jun 28, 2023

muncus deleted the eventarc_storage_handler branch June 28, 2023 19:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(eventarc): new sample for storage event receiver #10222

feat(eventarc): new sample for storage event receiver #10222

Uh oh!

muncus commented Jun 12, 2023

Uh oh!

snippet-bot bot commented Jun 13, 2023 •

edited

Loading

Uh oh!

muncus commented Jun 14, 2023

Uh oh!

grayside left a comment

Uh oh!

Uh oh!

Uh oh!

grayside left a comment

Uh oh!

Uh oh!

grayside Jun 26, 2023

Uh oh!

muncus Jun 27, 2023

Uh oh!

muncus commented Jun 27, 2023

Uh oh!

rsamborski commented Jun 28, 2023 •

edited

Loading

Uh oh!

Uh oh!

feat(eventarc): new sample for storage event receiver #10222

feat(eventarc): new sample for storage event receiver #10222

Uh oh!

Conversation

muncus commented Jun 12, 2023

Description

Checklist

Uh oh!

snippet-bot bot commented Jun 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

muncus commented Jun 14, 2023

Uh oh!

grayside left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

grayside left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

grayside Jun 26, 2023

Choose a reason for hiding this comment

Uh oh!

muncus Jun 27, 2023

Choose a reason for hiding this comment

Uh oh!

muncus commented Jun 27, 2023

Uh oh!

rsamborski commented Jun 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

snippet-bot bot commented Jun 13, 2023 •

edited

Loading

rsamborski commented Jun 28, 2023 •

edited

Loading