Skip to content

Commit d4249bb

Browse files
feat!: use RecommendationName, remove deprecated recommendation name helper methods (#79)
* [CHANGE ME] Re-generated to pick up changes in the API or client library generator. * allow removal of deprecated methods Co-authored-by: Jeff Ching <[email protected]>
1 parent e63bf28 commit d4249bb

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

recommender/src/main/java/com/google/cloud/examples/recommender/v1beta1/SampleListRecommendations.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2019 Google LLC
2+
* Copyright 2020 Google LLC
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -25,6 +25,7 @@
2525
import com.google.cloud.recommender.v1beta1.ListRecommendationsRequest;
2626
import com.google.cloud.recommender.v1beta1.Recommendation;
2727
import com.google.cloud.recommender.v1beta1.RecommenderClient;
28+
import com.google.cloud.recommender.v1beta1.RecommenderName;
2829

2930
public class SampleListRecommendations {
3031
// [START ]
@@ -34,15 +35,15 @@ public class SampleListRecommendations {
3435
* import com.google.cloud.recommender.v1beta1.ListRecommendationsRequest;
3536
* import com.google.cloud.recommender.v1beta1.Recommendation;
3637
* import com.google.cloud.recommender.v1beta1.RecommenderClient;
38+
* import com.google.cloud.recommender.v1beta1.RecommenderName;
3739
*/
3840

3941
/** List recommendations for a specified project, location, and recommender. */
4042
public static void sampleListRecommendations() {
4143
try (RecommenderClient recommenderClient = RecommenderClient.create()) {
42-
String formattedParent =
43-
RecommenderClient.formatRecommenderName("[PROJECT]", "[LOCATION]", "[RECOMMENDER]");
44+
RecommenderName parent = RecommenderName.of("[PROJECT]", "[LOCATION]", "[RECOMMENDER]");
4445
ListRecommendationsRequest request =
45-
ListRecommendationsRequest.newBuilder().setParent(formattedParent).build();
46+
ListRecommendationsRequest.newBuilder().setParent(parent.toString()).build();
4647
for (Recommendation responseItem :
4748
recommenderClient.listRecommendations(request).iterateAll()) {
4849
Recommendation recommendation = responseItem;

0 commit comments

Comments
 (0)