fix: replace the hardcoded default version string (#1836) #1900
Conversation
|
|
||
| // versionString indiciates the version of the proxy currently in use. | ||
| // | ||
| //go:embed version.txt |
There was a problem hiding this comment.
You'll need to move version.txt to this directory.
Also, we'll need to update the location of this file in .github/release-please.yml.
There was a problem hiding this comment.
version.txt has been moved under proxy/util.
It seems to me that v1 branch doesn't have .github/release-please.yml file. Instead .build/release_artifacts.sh refers to version.txt. I'll update it that one.
There was a problem hiding this comment.
Jack told me offline that the release-please.yml file in main branch needs to be updated. So created this PR #1904. Please let me know if that looks OK. Thanks!
annafang-google
force-pushed
the
fix-verison-v1
branch
from
6d1fdb5 to
7cf85fb
Compare
annafang-google
force-pushed
the
fix-verison-v1
branch
from
7cf85fb to
6589ef3
Compare
jackwotherspoon
left a comment
jackwotherspoon
left a comment
There was a problem hiding this comment.
LGTM ✅ Let's wait and let @enocom take a look on Monday before merging though
proxy/util/cloudsqlutil.go
Outdated
| //go:embed version.txt | ||
| var versionString string | ||
|
|
||
| // metadataString indiciates additional build or distribution metadata. |
There was a problem hiding this comment.
Good catch! Fixed.
proxy/util/cloudsqlutil.go
Outdated
| return v | ||
| } | ||
|
|
||
| // userAgentFromVersionString returns an appropriate user agent string for identifying this proxy process. |
There was a problem hiding this comment.
Let's try to wrap at 80 characters here.
There was a problem hiding this comment.
Good catch! Fixed.
Remove empty line fixed cloudsqlutil.go format fix test code Fixed the typo in the test message Fixed typo and wrapped the long line
annafang-google
force-pushed
the
fix-verison-v1
branch
from
6589ef3 to
ad605cb
Compare
3 participants
Replace hardcoded default version string with the one specified in version.txt.