Skip to content

Conversation

@nolanmar511
Copy link
Contributor

Copy configs to final locations.

After these changes are completed, all configs in kokoro/continuous, kokoro/presubmit, and kokoro/release will be deleted.

Release configs will be deleted now that pprof-nodejs contains the native component. We will use the release workflow used by other node modules in the googleapis organization.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 26, 2019
@aalexand
Copy link
Contributor

@nolanmar511 In the final state only one of the .kokoro vs. tools/kokoro locations will exist? The difference between the two is currently unclear.

@nolanmar511
Copy link
Contributor Author

tools/kokoro our system tests (which we maintain). I'm happy to make any changes to the kokoro configs these.

.kokoro is unit tests (and hopefully soon a release job). jkwlui maintains this. This directory is common to Node.JS modules under googleapis (for example, https://github.com/googleapis/cloud-debug-nodejs/tree/master/.kokoro). I really don't want to make any changes to this directory -- I want it to be as easy as possible for the client libraries team to maintain kokoro jobs across multiple repositories.

So, we will have two locations for our kokoro configs. Maybe I should rename and re-structure tools directory so it matches .kokoro.

We could, for example replace the tools directory with the following:

.kokoro-system-test

  • continuous
    • system-test.cfg
    • v8-canary-system-test.cfg
  • presubmit
    • system-test.cfg

@aalexand
Copy link
Contributor

@nolanmar511 I see. Maybe at least add a tools/kokoro/README.md and .kokoro/README.md file explaining the intent of each location and its counterpart.

@nolanmar511 nolanmar511 force-pushed the reorg-kokoro-configs branch from 356eb64 to 14ddb49 Compare March 27, 2019 20:05
@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #441 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #441   +/-   ##
=======================================
  Coverage   75.94%   75.94%           
=======================================
  Files           4        4           
  Lines         212      212           
  Branches       24       24           
=======================================
  Hits          161      161           
  Misses         48       48           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b9a64...2d56690. Read the comment docs.

@nolanmar511 nolanmar511 force-pushed the reorg-kokoro-configs branch from 14ddb49 to d224322 Compare March 27, 2019 20:12
@nolanmar511
Copy link
Contributor Author

All of our remaining kokoro configs are for system tests, so I moved them all into a "system-test" directory (I also renamed the "testing" directory "system-test").

There's already a README.md in the system-test directory; I added a README.md to the .kokoro directory.

@nolanmar511 nolanmar511 force-pushed the reorg-kokoro-configs branch 4 times, most recently from 5c9f415 to efb5806 Compare March 28, 2019 15:23
@aalexand
Copy link
Contributor

@nolanmar511 Kokoro CI fails?

@nolanmar511 nolanmar511 force-pushed the reorg-kokoro-configs branch from efb5806 to dfba852 Compare April 2, 2019 21:31
@nolanmar511 nolanmar511 force-pushed the reorg-kokoro-configs branch from dfba852 to 117a971 Compare April 2, 2019 21:39
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 3, 2019
@nolanmar511
Copy link
Contributor Author

npm audit is failing because of Mocha.
snyk fails because I moved busybench. Based on the "details" link for that failure, I'm going to update the location after I merge this change.

@nolanmar511 nolanmar511 merged commit 56adf2d into googleapis:master Apr 3, 2019
@nolanmar511 nolanmar511 deleted the reorg-kokoro-configs branch April 3, 2019 15:22
@nolanmar511
Copy link
Contributor Author

Kokoro CI also is passing. It failed earlier, because I didn't update all references to files that I had moved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants