-
Notifications
You must be signed in to change notification settings - Fork 27
chore: copy configs to begin reorganizing kokoro configs #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: copy configs to begin reorganizing kokoro configs #441
Conversation
|
@nolanmar511 In the final state only one of the .kokoro vs. tools/kokoro locations will exist? The difference between the two is currently unclear. |
|
tools/kokoro our system tests (which we maintain). I'm happy to make any changes to the kokoro configs these. .kokoro is unit tests (and hopefully soon a release job). jkwlui maintains this. This directory is common to Node.JS modules under googleapis (for example, https://github.com/googleapis/cloud-debug-nodejs/tree/master/.kokoro). I really don't want to make any changes to this directory -- I want it to be as easy as possible for the client libraries team to maintain kokoro jobs across multiple repositories. So, we will have two locations for our kokoro configs. Maybe I should rename and re-structure tools directory so it matches .kokoro. We could, for example replace the tools directory with the following: .kokoro-system-test
|
|
@nolanmar511 I see. Maybe at least add a tools/kokoro/README.md and .kokoro/README.md file explaining the intent of each location and its counterpart. |
356eb64 to
14ddb49
Compare
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
=======================================
Coverage 75.94% 75.94%
=======================================
Files 4 4
Lines 212 212
Branches 24 24
=======================================
Hits 161 161
Misses 48 48
Partials 3 3Continue to review full report at Codecov.
|
14ddb49 to
d224322
Compare
|
All of our remaining kokoro configs are for system tests, so I moved them all into a "system-test" directory (I also renamed the "testing" directory "system-test"). There's already a README.md in the system-test directory; I added a README.md to the .kokoro directory. |
5c9f415 to
efb5806
Compare
|
@nolanmar511 Kokoro CI fails? |
efb5806 to
dfba852
Compare
dfba852 to
117a971
Compare
|
npm audit is failing because of Mocha. |
|
Kokoro CI also is passing. It failed earlier, because I didn't update all references to files that I had moved. |
Copy configs to final locations.
After these changes are completed, all configs in kokoro/continuous, kokoro/presubmit, and kokoro/release will be deleted.
Release configs will be deleted now that pprof-nodejs contains the native component. We will use the release workflow used by other node modules in the googleapis organization.