-
-
Notifications
You must be signed in to change notification settings - Fork 346
Remote abstraction #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remote abstraction #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare to free up the remote module for actual remote handling
Needs more tests to see it actually finds remotes with names.
…onfiguration exists. (#450)
…ote for a a direction. (#450)
With many tests still missing.
…heir instruction (#450) That way, it's possible to treat dissimilar yet effectively equal specs like they are equal.
…e the originals. (#450)
… URLs. (#450) They can contain paths, which is why `String` can't repsent a URL losslessly. For HTTP urls these are ultimately UTF-8 strings though.
Prepare for `protocol` configuration.
…i_]value`. (#450) This makes clear that the method will fail if the value doesn't yet exist.
…ew section for mutation. (#450)
…lues, and make the value itself easier to provide. (#450)
…ues in memory. (#450) It's a first step towards writing changes back to disk, which can work already, but probably wouldn't as we currently don't localize changes to only one section type, i.e. Api, but instead may change values from other sections.
…ch sections to add values to. (#450)
…assing a filter. (#450)
…ecial mechanism. (#450)
…ue separator. (#450) These make a difference as those without `=` are considered boolean true. Currently pushing onto a section is the only way to write them.
…t. (#450) This also changes behaviour, but merely removes a hack in `Boolean` which considered empty strings true, even though they are supposed to be false.
… things like `-c` (#450)
…fs` (#450) The functinality is the same, but the latter is built on top of a repository which is slightly less flexible, but preferable over maintaining a non-repo version.
… false. (#450) This is even consistent when no booleans are used, such that `a` has no value as if it is not present, it's only available for booleans which must be specified.
22 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First steps towards interacting with and using remotes.
Tasks
Head::into_remote(…)
git_url::Url::to_bstring()
limited async connect (port fromneeds a runtime choice, how to abstract that?gitoxide-core
)gix remote refs
command to dry-run a fetch essentially showing what would be fetched, which branches would be updated, and how many remote references have been ignored due to refspec.git-config
For follow-up PR
protocol.*.allow
Out of scope
credential.helper
configuration (via git-sec)branch.<name>.merge
support, as we don't yet merge anything and fetching still fetches the entire refspec of as configured in the remote.