Refactor git_config::values #338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
svetli-n
commented
Feb 19, 2022
svetli-n
commented
- Remove creating values from str
- Rename Other to Bytes
Byron
reviewed
Feb 21, 2022
svetli-n
force-pushed
the
remove_str_handling
branch
from
389355a to
9a89c6c
Compare
svetli-n
commented
Feb 21, 2022
Closed
24 tasks
|
Thanks a lot for your second contribution, paving the way for more to come :). |
|
Closing this PR as it was pushed to main in a squashed form. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.