Skip to content

RevSpec parsing #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 5 tasks
Tracked by #411
Byron opened this issue May 12, 2022 · 0 comments
Open
1 of 5 tasks
Tracked by #411

RevSpec parsing #413

Byron opened this issue May 12, 2022 · 0 comments
Labels
C-tracking-issue An issue to track to track the progress of multiple PRs or issues

Comments

@Byron
Copy link
Member

Byron commented May 12, 2022

Basic Parsing

It would be great to be part of the development in case you want to open a draft PR sooner than later. Parsing would go into the git-revision crate and have the following requirements.

  • parse plain bytes (or &BStr), not &str
  • call functions to signal which item was parsed, that is it doesn't parse into a data structure

Also see this discussion for more insights.

  • a callback based parser

Revision Ranges

Prerequisistes

@Byron Byron added the C-tracking-issue An issue to track to track the progress of multiple PRs or issues label May 12, 2022
This was referenced May 12, 2022
Byron added a commit that referenced this issue May 13, 2022
Byron added a commit that referenced this issue May 13, 2022
Byron added a commit that referenced this issue May 13, 2022
avoid allocation
Byron added a commit that referenced this issue May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue An issue to track to track the progress of multiple PRs or issues
Projects
None yet
Development

No branches or pull requests

1 participant