Completely remove :/ baseline skip

This rolls back all changes made to work around the Git 2.47.* bug
that underlies #1622, including the change made in the immediately
preceding commit.

This undoes the changes to `regex.rs` from #1635, #1719, #1774, and
2400158 (which is the immediately preceding commit). That file is
now as it was in 3745212.

The rationale is that the disadvantages of inverting the CI check
and extending the suppresson, as described in the previous commit,
really outweigh the advantages. This is mainly due to the risk of
generating archives that should not be committed but seem based on
test results like they could be committed.

(The suppressions being removed here will most likely not be needed
in the future, but if they are then this commit can be reverted,
and the suppression will be done locally but on on CI, consistently
across feature for which the relevant tests are run, and only when
Git is found to be a version in the 2.47.* range.)

Closes #1622

Author: EliahKagan

gix/tests/gix/revision/spec/from_bytes/regex.rs

@@ -67,40 +67,21 @@ mod find_youngest_matching_commit {
     fn contained_string_matches() {
         let repo = repo("complex_graph").unwrap();
 
-        // See the comment on `skip_some_baselines` in the `regex_matches` test function below.
-        let skip_some_baselines = !is_ci::cached()
-            && std::env::var_os("GIX_TEST_IGNORE_ARCHIVES").is_some()
-            && ((2, 47, 0)..(2, 48, 0)).contains(&gix_testtools::GIT_VERSION);
-
-        if skip_some_baselines {
-            assert_eq!(
-                parse_spec_no_baseline(":/message", &repo).unwrap(),
-                Spec::from_id(hex_to_id("ef80b4b77b167f326351c93284dc0eb00dd54ff4").attach(&repo))
-            );
-        } else {
-            assert_eq!(
-                parse_spec(":/message", &repo).unwrap(),
-                Spec::from_id(hex_to_id("ef80b4b77b167f326351c93284dc0eb00dd54ff4").attach(&repo))
-            );
-        }
+        assert_eq!(
+            parse_spec(":/message", &repo).unwrap(),
+            Spec::from_id(hex_to_id("ef80b4b77b167f326351c93284dc0eb00dd54ff4").attach(&repo))
+        );
 
         assert_eq!(
             parse_spec("@^{/!-B}", &repo).unwrap(),
             Spec::from_id(hex_to_id("55e825ebe8fd2ff78cad3826afb696b96b576a7e").attach(&repo)),
             "negations work as well"
         );
 
-        if skip_some_baselines {
-            assert_eq!(
-                parse_spec_no_baseline(":/!-message", &repo).unwrap(),
-                Spec::from_id(hex_to_id("55e825ebe8fd2ff78cad3826afb696b96b576a7e").attach(&repo))
-            );
-        } else {
-            assert_eq!(
-                parse_spec(":/!-message", &repo).unwrap(),
-                Spec::from_id(hex_to_id("55e825ebe8fd2ff78cad3826afb696b96b576a7e").attach(&repo))
-            );
-        }
+        assert_eq!(
+            parse_spec(":/!-message", &repo).unwrap(),
+            Spec::from_id(hex_to_id("55e825ebe8fd2ff78cad3826afb696b96b576a7e").attach(&repo))
+        );
 
         assert_eq!(
             parse_spec_no_baseline(":/messa.e", &repo).unwrap_err().to_string(),
@@ -114,52 +95,20 @@ mod find_youngest_matching_commit {
     fn regex_matches() {
         let repo = repo("complex_graph").unwrap();
 
-        // Traversal order with `:/` was broken in Git 2.47.*, so some `parse_spec` assertions
-        // fail. The fix is in Git 2.48.* but is not backported. This causes incorrect baselines to
-        // be computed when `GIX_TEST_IGNORE_ARCHIVES` is set. If that is not set, then archived
-        // baselines are used and there is no problem. On CI, we assume a sufficiently new version
-        // of Git. Otherwise, if `GIX_TEST_IGNORE_ARCHIVES` is set and Git 2.47.* is used, we skip
-        // the baseline check, to allow the rest of the test to proceed. This accommodates local
-        // development environments with a system-provided Git 2.47.*, though archives generated on
-        // such a system should not be committed, as they would still contain incorrect baselines.
-        // Please note that this workaround may be removed in the future. For more details, see:
-        //
-        //  - https://lore.kernel.org/git/[email protected]/T/
-        //  - https://lore.kernel.org/git/[email protected]/T/
-        //  - https://github.com/git/git/blob/v2.48.0/Documentation/RelNotes/2.48.0.txt#L294-L296
-        //  - https://github.com/GitoxideLabs/gitoxide/issues/1622
-        let skip_some_baselines = !is_ci::cached()
-            && std::env::var_os("GIX_TEST_IGNORE_ARCHIVES").is_some()
-            && ((2, 47, 0)..(2, 48, 0)).contains(&gix_testtools::GIT_VERSION);
-
-        if skip_some_baselines {
-            assert_eq!(
-                parse_spec_no_baseline(":/mes.age", &repo).unwrap(),
-                Spec::from_id(hex_to_id("ef80b4b77b167f326351c93284dc0eb00dd54ff4").attach(&repo))
-            );
-        } else {
-            assert_eq!(
-                parse_spec(":/mes.age", &repo).unwrap(),
-                Spec::from_id(hex_to_id("ef80b4b77b167f326351c93284dc0eb00dd54ff4").attach(&repo))
-            );
-        }
+        assert_eq!(
+            parse_spec(":/mes.age", &repo).unwrap(),
+            Spec::from_id(hex_to_id("ef80b4b77b167f326351c93284dc0eb00dd54ff4").attach(&repo))
+        );
 
         assert_eq!(
             parse_spec(":/not there", &repo).unwrap_err().to_string(),
             "None of 10 commits reached from all references matched regex \"not there\""
         );
 
-        if skip_some_baselines {
-            assert_eq!(
-                parse_spec_no_baseline(":/!-message", &repo).unwrap(),
-                Spec::from_id(hex_to_id("55e825ebe8fd2ff78cad3826afb696b96b576a7e").attach(&repo))
-            );
-        } else {
-            assert_eq!(
-                parse_spec(":/!-message", &repo).unwrap(),
-                Spec::from_id(hex_to_id("55e825ebe8fd2ff78cad3826afb696b96b576a7e").attach(&repo))
-            );
-        }
+        assert_eq!(
+            parse_spec(":/!-message", &repo).unwrap(),
+            Spec::from_id(hex_to_id("55e825ebe8fd2ff78cad3826afb696b96b576a7e").attach(&repo))
+        );
 
         assert_eq!(
             parse_spec("@^{/!-B}", &repo).unwrap(),