fix lints for nightly, and clippy

Author: Byron

gitoxide-core/src/repository/credential.rs

@@ -1,5 +1,3 @@
-use std::convert::TryInto;
-
 #[derive(Debug, thiserror::Error)]
 enum Error {
     #[error(transparent)]

gix-actor/src/lib.rs

@@ -22,6 +22,7 @@ use gix_date::Time;
 
 mod identity;
 ///
+#[allow(clippy::empty_docs)]
 pub mod signature;
 
 /// A person with name and email.

gix-actor/src/signature/mod.rs

@@ -129,5 +129,6 @@ pub(crate) mod write {
 }
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod decode;
 pub use decode::function::decode;

gix-attributes/src/lib.rs

@@ -13,14 +13,18 @@ use kstring::{KString, KStringRef};
 
 mod assignment;
 ///
+#[allow(clippy::empty_docs)]
 pub mod name;
 ///
+#[allow(clippy::empty_docs)]
 pub mod state;
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod search;
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod parse;
 
 /// Parse attribute assignments line by line from `bytes`, and fail the operation on error.

gix-attributes/src/search/outcome.rs

@@ -26,7 +26,7 @@ impl Outcome {
             for (order, macro_attributes) in collection.iter().filter_map(|(_, meta)| {
                 (!meta.macro_attributes.is_empty()).then_some((meta.id.0, &meta.macro_attributes))
             }) {
-                self.matches_by_id[order].macro_attributes = macro_attributes.clone()
+                self.matches_by_id[order].macro_attributes.clone_from(macro_attributes)
             }
 
             for (name, id) in self.selected.iter_mut().filter(|(_, id)| id.is_none()) {
@@ -88,7 +88,7 @@ impl Outcome {
     /// Note that it's safe to call it multiple times, so that it can be called after this instance was used to store a search result.
     pub fn copy_into(&self, collection: &MetadataCollection, dest: &mut Self) {
         dest.initialize(collection);
-        dest.matches_by_id = self.matches_by_id.clone();
+        dest.matches_by_id.clone_from(&self.matches_by_id);
         if dest.patterns.len() != self.patterns.len() {
             dest.patterns = self.patterns.clone();
         }
@@ -325,7 +325,11 @@ impl MetadataCollection {
         };
 
         self.assign_order_to_attributes(attrs);
-        self.name_to_meta.get_mut(name).expect("just added").macro_attributes = attrs.clone();
+        self.name_to_meta
+            .get_mut(name)
+            .expect("just added")
+            .macro_attributes
+            .clone_from(attrs);
 
         order
     }

gix-bitmap/src/ewah.rs

@@ -1,6 +1,5 @@
-use std::convert::TryInto;
-
 ///
+#[allow(clippy::empty_docs)]
 pub mod decode {
     /// The error returned by [`decode()`][super::decode()].
     #[derive(Debug, thiserror::Error)]
@@ -52,8 +51,6 @@ pub fn decode(data: &[u8]) -> Result<(Vec, &[u8]), decode::Error> {
 }
 
 mod access {
-    use std::convert::{TryFrom, TryInto};
-
     use super::Vec;
 
     impl Vec {

gix-bitmap/src/lib.rs

@@ -7,8 +7,6 @@
 pub mod ewah;
 
 pub(crate) mod decode {
-    use std::convert::TryInto;
-
     #[inline]
     pub(crate) fn split_at_pos(data: &[u8], pos: usize) -> Option<(&[u8], &[u8])> {
         if data.len() < pos {

gix-chunk/src/file/decode.rs

@@ -1,4 +1,4 @@
-use std::{convert::TryInto, ops::Range};
+use std::ops::Range;
 
 mod error {
     /// The value returned by [`crate::file::Index::from_bytes()`]

gix-chunk/src/file/index.rs

@@ -3,6 +3,7 @@ use std::ops::Range;
 use crate::file::Index;
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod offset_by_kind {
     use std::fmt::{Display, Formatter};
 
@@ -27,6 +28,7 @@ pub mod offset_by_kind {
 }
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod data_by_kind {
     /// The error returned by [`Index::data_by_id()`][super::Index::data_by_id()].
     #[derive(Debug, thiserror::Error)]

gix-chunk/src/file/mod.rs

@@ -1,9 +1,12 @@
 ///
+#[allow(clippy::empty_docs)]
 pub mod decode;
 ///
+#[allow(clippy::empty_docs)]
 pub mod index;
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod write;
 
 /// The offset to a chunk as seen relative to the beginning of the file containing it.