Fix conflict detection logic #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
reviewed
Apr 23, 2023
|
It's basically 3 PRs in one, review each commit differently |
silverwind
approved these changes
Apr 23, 2023
delvh
reviewed
Apr 23, 2023
| const milestoneToPr = new Map<string, number[]>(); | ||
| const milestoneToPr = new Map< | ||
| string, | ||
| { number: number; user: { login: string } }[] |
There was a problem hiding this comment.
What about name instead of login?
I had to look below to find out that you mean the name, and not some type of secret or authentication method…
There was a problem hiding this comment.
Ah wait, does it come like that from the GitHub API?
If yes, ignore my comment.
There was a problem hiding this comment.
If no, then why do you not assign the user manually?
There was a problem hiding this comment.
it's from the GitHub API
yardenshoham
added a commit
that referenced
this pull request
Apr 23, 2023
Regression from #53 Signed-off-by: Yarden Shoham <[email protected]>
yardenshoham
added a commit
that referenced
this pull request
Apr 23, 2023
Regression from #53 Signed-off-by: Yarden Shoham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
break), fixes Wrong remind about conflicts #52