Cache version information to disk #711
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| using System; | ||
| using System.Collections.Concurrent; | ||
| using System.Text; | ||
|
|
||
| using GitVersion; | ||
| using GitVersion.Helpers; | ||
|
|
||
| using NUnit.Framework; | ||
|
|
||
| using Shouldly; | ||
|
|
||
| [TestFixture] | ||
| public class ExecuteCoreTests | ||
| { | ||
| IFileSystem fileSystem; | ||
|
|
||
|
|
||
| [SetUp] | ||
| public void SetUp() | ||
| { | ||
| this.fileSystem = new FileSystem(); | ||
| } | ||
|
|
||
|
|
||
| [Test] | ||
| public void CacheFileExistsOnDisk() | ||
| { | ||
| const string versionCacheFileContent = @" | ||
| Major: 4 | ||
| Minor: 10 | ||
| Patch: 3 | ||
| PreReleaseTag: test.19 | ||
| PreReleaseTagWithDash: -test.19 | ||
| BuildMetaData: | ||
| BuildMetaDataPadded: | ||
| FullBuildMetaData: Branch.feature/test.Sha.dd2a29aff0c948e1bdf3dabbe13e1576e70d5f9f | ||
| MajorMinorPatch: 4.10.3 | ||
| SemVer: 4.10.3-test.19 | ||
| LegacySemVer: 4.10.3-test19 | ||
| LegacySemVerPadded: 4.10.3-test0019 | ||
| AssemblySemVer: 4.10.3.0 | ||
| FullSemVer: 4.10.3-test.19 | ||
| InformationalVersion: 4.10.3-test.19+Branch.feature/test.Sha.dd2a29aff0c948e1bdf3dabbe13e1576e70d5f9f | ||
| BranchName: feature/test | ||
| Sha: dd2a29aff0c948e1bdf3dabbe13e1576e70d5f9f | ||
| NuGetVersionV2: 4.10.3-test0019 | ||
| NuGetVersion: 4.10.3-test0019 | ||
| CommitsSinceVersionSource: 19 | ||
| CommitsSinceVersionSourcePadded: 0019 | ||
| CommitDate: 2015-11-10 | ||
| "; | ||
|
|
||
| var versionAndBranchFinder = new ExecuteCore(this.fileSystem); | ||
|
|
||
| var info = RepositoryScope(versionAndBranchFinder, (fixture, vv) => | ||
| { | ||
| this.fileSystem.WriteAllText(vv.FileName, versionCacheFileContent); | ||
| vv = versionAndBranchFinder.ExecuteGitVersion(null, null, null, null, false, fixture.RepositoryPath, null); | ||
| vv.AssemblySemVer.ShouldBe("4.10.3.0"); | ||
| }); | ||
|
|
||
| info.ShouldContain("Deserializing version variables from cache file", () => info); | ||
| } | ||
|
|
||
|
|
||
| [Test] | ||
| public void CacheFileExistsInMemory() | ||
| { | ||
| var cache = new ConcurrentDictionary<string, VersionVariables>(); | ||
| var versionAndBranchFinder = new ExecuteCore(this.fileSystem, cache.GetOrAdd); | ||
|
|
||
| var info = RepositoryScope(versionAndBranchFinder, (fixture, vv) => | ||
| { | ||
| vv = versionAndBranchFinder.ExecuteGitVersion(null, null, null, null, false, fixture.RepositoryPath, null); | ||
| vv.AssemblySemVer.ShouldBe("0.1.0.0"); | ||
| }); | ||
|
|
||
| info.ShouldContain("yml not found", () => info); | ||
| info.ShouldNotContain("Deserializing version variables from cache file", () => info); | ||
| } | ||
|
|
||
|
|
||
| [Test] | ||
| public void CacheFileIsMissing() | ||
| { | ||
| var info = RepositoryScope(); | ||
| info.ShouldContain("yml not found", () => info); | ||
| } | ||
|
|
||
|
|
||
| string RepositoryScope(ExecuteCore executeCore = null, Action<EmptyRepositoryFixture, VersionVariables> fixtureAction = null) | ||
| { | ||
| var infoBuilder = new StringBuilder(); | ||
| Action<string> infoLogger = s => { infoBuilder.AppendLine(s); }; | ||
| executeCore = executeCore ?? new ExecuteCore(this.fileSystem); | ||
|
|
||
| Logger.SetLoggers(infoLogger, s => { }, s => { }); | ||
|
|
||
| using (var fixture = new EmptyRepositoryFixture(new Config())) | ||
| { | ||
| fixture.Repository.MakeACommit(); | ||
| var vv = executeCore.ExecuteGitVersion(null, null, null, null, false, fixture.RepositoryPath, null); | ||
|
|
||
| vv.AssemblySemVer.ShouldBe("0.1.0.0"); | ||
| vv.FileName.ShouldNotBeNullOrEmpty(); | ||
|
|
||
| if (fixtureAction != null) | ||
| { | ||
| fixtureAction(fixture, vv); | ||
| } | ||
| } | ||
|
|
||
| return infoBuilder.ToString(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,52 +1,97 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.IO; | ||
| using System.Text; | ||
|
|
||
| using GitVersion.Helpers; | ||
|
|
||
| using LibGit2Sharp; | ||
|
|
||
| public class TestFileSystem : IFileSystem | ||
| { | ||
| Dictionary<string, string> fileSystem = new Dictionary<string, string>(); | ||
|
|
||
|
|
||
| public void Copy(string @from, string to, bool overwrite) | ||
| { | ||
| throw new NotImplementedException(); | ||
| } | ||
|
|
||
|
|
||
| public void Move(string @from, string to) | ||
| { | ||
| throw new NotImplementedException(); | ||
| } | ||
|
|
||
|
|
||
| public bool Exists(string file) | ||
| { | ||
| return this.fileSystem.ContainsKey(file); | ||
| } | ||
|
|
||
|
|
||
| public void Delete(string path) | ||
| { | ||
| throw new NotImplementedException(); | ||
| } | ||
|
|
||
|
|
||
| public string ReadAllText(string path) | ||
| { | ||
| return this.fileSystem[path]; | ||
| } | ||
|
|
||
|
|
||
| public void WriteAllText(string file, string fileContents) | ||
| { | ||
| if (this.fileSystem.ContainsKey(file)) | ||
| { | ||
| this.fileSystem[file] = fileContents; | ||
| } | ||
| else | ||
| { | ||
| this.fileSystem.Add(file, fileContents); | ||
| } | ||
| } | ||
|
|
||
|
|
||
| public IEnumerable<string> DirectoryGetFiles(string directory, string searchPattern, SearchOption searchOption) | ||
| { | ||
| throw new NotImplementedException(); | ||
| } | ||
|
|
||
|
|
||
| public Stream OpenWrite(string path) | ||
| { | ||
| return new TestStream(path, this); | ||
| } | ||
|
|
||
|
|
||
| public Stream OpenRead(string path) | ||
| { | ||
| if (this.fileSystem.ContainsKey(path)) | ||
| { | ||
| var content = this.fileSystem[path]; | ||
| return new MemoryStream(Encoding.UTF8.GetBytes(content)); | ||
| } | ||
|
|
||
| throw new FileNotFoundException("File not found.", path); | ||
| } | ||
|
|
||
|
|
||
| public void CreateDirectory(string path) | ||
| { | ||
| } | ||
|
|
||
|
|
||
| public long GetLastDirectoryWrite(string path) | ||
| { | ||
| return 1; | ||
| } | ||
|
|
||
|
|
||
| public IRepository GetRepository(string gitDirectory) | ||
|
There was a problem hiding this comment. Why not use the Fixture stuff? Mocking out libgit2sharp stuff is annoying in the long run I think There was a problem hiding this comment. @JakeGinnivan Yea, I ended up using the fixture stuff, which is why I ask what is causing the following exception:
Why are none of the other tests using the fixture having this problem? I see no mention of any remotes. |
||
| { | ||
| throw new NotImplementedException(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GeertvanHorrik fyi. Maybe just make the file system stuff internal in Core. The needed abstractions will be different in each app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I hoped the abstraction would be useful, but I ended up not using it. Mocking with
staticclasses and methods is nigh impossible.