Skip to content

(GH-2679) Support release branch naming with MAJOR SemVer number only #2699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mglochsen
Copy link
Contributor

@mglochsen mglochsen commented May 20, 2021

This is a PR for #2679 (Support release branch naming with MAJOR SemVer number only)

Description

Modified the regex for semantic versioning and added tests for the new possible version parsing.
It is now possible to parse just the major or the major and the minor version.

Related Issue

Resolves #2679 (Support release branch naming with MAJOR SemVer number only)

Motivation and Context

It is now possible to use release branches such as release/1 or release/1.1 and GitVersion will parse 1.0.0 or 1.1.0 for it.

How Has This Been Tested?

There are two new test cases in the class SemanticVersionTests.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 👍🏼

@asbjornu asbjornu merged commit e8774a8 into GitTools:main May 20, 2021
@mergify
Copy link
Contributor

mergify bot commented May 20, 2021

Thank you @mglochsen for your contribution!

@mglochsen mglochsen deleted the feature/2679-release-branch-naming-with-major-only branch May 21, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support release branch naming with MAJOR SemVer number only
2 participants