Skip to content

Add fallback values for GitVersionFileExe and GitVersionAssemblyFile #2507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

ermshiperete
Copy link
Contributor

This fixes #2502.

@arturcic
Copy link
Member

arturcic commented Jan 4, 2021

will this work for net5.0-windows?

@ermshiperete
Copy link
Contributor Author

ermshiperete commented Jan 4, 2021

will this work for net5.0-windows?

Good question. It will work if .NET Core 3.1 is installed, but if it isn't installed (and you run into the bug in #2502) it probably won't work. And if we change it to fall back to net5.0 it won't work if .NET Core 3.1 isn't installed...

@arturcic
Copy link
Member

arturcic commented Jan 8, 2021

Closing in favor of #2521

@arturcic arturcic closed this Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Build with GitVersion.MsBuild fails because GitVersionFileExe is not set
2 participants