Replace [^a-zA-Z0-9-] with - in BranchName variable #2008
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anch name variable can never be used in any SemVer spec since it can contain a / when using nested branches.
KiLLeRRaT
force-pushed
the
branchNameSlash
branch
from
c603052 to
8db59be
Compare
|
The BranchName variable has not direct connection with the SemVer. |
|
The issue will be resolved in #2014 |
|
@Skoucail Excellent, thank you for that! You can then close this PR. Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the branch name variable can never be used in any SemVer spec since it can contain a / when using nested branches.
My reasoning to just always replace it is that people will only use the branch name variable when trying to put together a GitVersion tag, which should be SemVer compliant. So no need to make this setting driven or introduce a new variable just for this.
Cheers,