CentOS 7 docker based image #1571

mr-exz · 2019-01-19T22:17:56Z

added Dockerfile with:

clear cenots/7
dotnet core 2.2
gitversion 4.0.0

added Dockerfile with clear cenots/7,dotnet core 2.2, gitversion 4.0.0

asbjornu · 2019-01-21T08:15:46Z

Thanks for this, @mr-exz. Is it possible to add an automatic test that is run by Travis or similar, somehow?

arturcic · 2019-01-21T08:29:25Z

@mr-exz thanks for the contribution, we currently publish the docker images as part of the build process. In order to get this PR merged we need to change the way the docker image is built, meaning the image should use the artifact from the build itself and not from Github release, that means we need to include in the build scripts. Currently we have 2 variants of the linux images - one using dotnet core and another using mono. Would be great to have the mono version as well.

For the build scripts we'll need to support building for different distros of Linux here and here

So for now I would suggest to update the build script to allow building for several distro of Linux, then adjust the DockerFile to use the artifacts from the build itself

mr-exz · 2019-01-21T11:00:34Z

Thanks for this, @mr-exz. Is it possible to add an automatic test that is run by Travis or similar, somehow?

i will check how you did it, and will try fit my Dockerfile into build process

mr-exz · 2019-01-21T20:07:18Z

@asbjornu @arturcic pls check changes

src/Docker/linux/centos/Dockerfile

asbjornu · 2019-01-22T10:41:53Z

build.cake

@@ -622,6 +623,7 @@ Task("Publish-DockerHub")
    {
        DockerPush("linux", "dotnetcore", parameters);
        DockerPush("linux", "fullfx", parameters);
+        DockerPush("linux", "centos", parameters);


Please excuse my ignorance, but how is this going to affect the naming on DockerHub? I don't quite understand where the existing repositories gitversion-fullfx, gitversion-dotnetcore, gitversion and libgit2sharp-mono come from and how they relate to these DockerPush() statements. Will centos become a new tag in the gitversion-dotnetcore repository?

@asbjornu gitversion and libgit2sharp-mono are already obsolete, only fullfx and dotnetcore are maintained.

As for centos, that is right, the current changes will not create a tag under dotnetcore - good catch, we'll need to adjust the scripts to allow several distros of linux under dotnetcore and fullfx

this is the method where the tags are created https://github.com/GitTools/GitVersion/blob/master/build/utils.cake#L174

I see. I find it a bit unfortunate that we have 4 different repositories for variations of the same executable. Can we get rid of every repository that isn't called simply gitversion and follow NGINX' naming scheme for labels to distinguish different versions of the image? That would give us one repository with tags following the scheme {version}-{platform}-{framework}, for example:

4.0.0-centos

4.0.1-beta2-debian-fx

4.0.0-beta15-windows-dotnetcore

latest-ubuntu

latest-windows

stable-ubuntu

stable-windows

I know doing anything about this scheme is outside the scope of this PR, I just want to have a discussion on this so I know which options we have.

I suggest creating a separate issue, I can then implement it, and after that we can adjust this PR to the new scheme.

@asbjornu please create an issue with the proposed scheme and we can discuss it there

Sure, I've created #1572 for further discussion.

arturcic · 2019-02-20T12:44:26Z

@asbjornu can we postpone merging this till I get #1572 implemented ?

asbjornu · 2019-02-20T13:11:39Z

@arturcic, yep, that's the plan. 😃

arturcic · 2019-02-26T09:11:27Z

@mr-exz the #1572 was implemented and merged, can you rebase on top of master and add the CentOS support? Do you think we can also add Fedora support?

mr-exz · 2019-02-26T09:14:27Z

@mr-exz the #1572 was implemented and merged, can you rebase on top of master and add the CentOS support? Do you think we can also add Fedora support?

i think we can, i'll take a look

arturcic · 2019-03-04T19:12:47Z

@mr-exz , I think you should move the Dockerfile to the src/Docker/linux/centos/netcoreapp2.1 folder similar to debian version. This way we'll be able to add net core 2.2 version as well

arturcic · 2019-03-04T19:47:38Z

Looks great! Thank you for your contribution!

mr-exz · 2019-03-04T19:48:40Z

Not at all

mr-exz · 2019-03-05T04:45:19Z

@arturcic can you provide link on new centos7/fedora27 docker images link ?

arturcic · 2019-03-05T07:39:08Z

Yesterday when the PR was merged the Linux build has failed, some unit tests for some reason failed, now they work again. The tags can be found at https://hub.docker.com/r/gittools/gitversion/tags

arturcic · 2019-03-05T07:40:01Z

@mr-exz can you confirm that those docker images are valid and work as expected as I don't have time to test them these days?

mr-exz · 2019-03-05T07:40:54Z

i will, in process

arturcic · 2019-03-05T07:41:26Z

Thanks

mr-exz · 2019-03-05T07:44:49Z

For me working fine

# docker run --rm -v "$(pwd):/repo" gittools/gitversion:5.0.0-linux-centos7-netcoreapp2.1 /repo
# docker run --rm -v "$(pwd):/repo" gittools/gitversion:5.0.0-linux-fedora27-netcoreapp2.1 /repo

arturcic · 2019-03-05T07:46:28Z

great, thanks for the fedora image as well.

mr-exz · 2019-03-05T07:47:51Z

Not at all :)

arturcic · 2019-03-05T07:49:19Z

Btw, are you in a position to add a new PR for netcoreapp2.2? for linux images? That would be a great addition

mr-exz · 2019-03-05T07:50:42Z

ok will do, it shouldn't be so difficult

asbjornu · 2019-03-06T11:02:26Z

Hm, I just discovered that the tag gittools/gitversion:5.0.0-linux-centos7-netcoreapp2.1 has the version number 5.0.0 which indicates it’s a stable version. Since it isn’t, that’s a problem, no? Can we get the pre-release label into there so we only tag stable releases as such?

arturcic · 2019-03-06T11:08:48Z

There is also a tag gittools/gitversion:5.0.0-beta2-18-linux-centos7-netcoreapp2.1 that is the same as the one you mentioned. Basically on every new build we re-tag the 5.0.0-linux-centos7-netcoreapp2.1 to the newest version, as well as we tag with a pre-release tag. That means the pre-release tag will not change, but the the other tag gets updated with every new commit. (it's is similar to how latest tag is used in other projects, meaning it's always pointing to the latest, stable or not stable)

arturcic · 2019-03-06T11:10:51Z

@asbjornu, you can review this https://github.com/GitTools/GitVersion/blob/master/build/utils.cake#L163-L196

arturcic · 2019-03-06T11:12:30Z

And the versioning here https://github.com/GitTools/GitVersion/blob/master/build/version.cake#L23-L24

mr-exz · 2019-03-09T12:22:56Z

Btw, are you in a position to add a new PR for netcoreapp2.2? for linux images? That would be a great addition

#1633

asbjornu · 2019-03-13T14:50:34Z

@arturcic, thanks for the explanation. That sounds sensible to me. 👍

updated readme

001a42f

added Dockerfile with clear cenots/7,dotnet core 2.2, gitversion 4.0.0

mr-exz mentioned this pull request Jan 19, 2019

GitVersion is not working on CentOS 7 #1125

Closed

arturcic self-requested a review January 20, 2019 16:54

add build docker image in build process

23c8f65

arturcic reviewed Jan 22, 2019

View reviewed changes

src/Docker/linux/centos/Dockerfile Outdated Show resolved Hide resolved

fix dotnet version

3c1f783

asbjornu reviewed Jan 22, 2019

View reviewed changes

asbjornu mentioned this pull request Jan 22, 2019

Docker naming scheme #1572

Closed

asbjornu added this to the 5.0.0 milestone Feb 20, 2019

Merge branch 'master' into add-dockerfile-with-centos

96331e1

Merge branch 'master' into add-dockerfile-with-centos

1ab4f27

Merge branch 'master' into add-dockerfile-with-centos

5e07e5e

added fedora dockerfile and move to proper folder

6a127c3

arturcic merged commit b6e2fdf into GitTools:master Mar 4, 2019

arturcic added the Feature label Mar 7, 2019

CentOS 7 docker based image #1571

CentOS 7 docker based image #1571

Uh oh!

Conversation

mr-exz commented Jan 19, 2019

Uh oh!

asbjornu commented Jan 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arturcic commented Jan 21, 2019

Uh oh!

mr-exz commented Jan 21, 2019

Uh oh!

mr-exz commented Jan 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

asbjornu Jan 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arturcic Jan 22, 2019

Choose a reason for hiding this comment

Uh oh!

arturcic Jan 22, 2019

Choose a reason for hiding this comment

Uh oh!

asbjornu Jan 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arturcic Jan 22, 2019

Choose a reason for hiding this comment

Uh oh!

arturcic Jan 22, 2019

Choose a reason for hiding this comment

Uh oh!

asbjornu Jan 22, 2019

Choose a reason for hiding this comment

Uh oh!

arturcic commented Feb 20, 2019

Uh oh!

asbjornu commented Feb 20, 2019

Uh oh!

arturcic commented Feb 26, 2019

Uh oh!

mr-exz commented Feb 26, 2019

Uh oh!

arturcic commented Mar 4, 2019

Uh oh!

arturcic commented Mar 4, 2019

Uh oh!

mr-exz commented Mar 4, 2019

Uh oh!

mr-exz commented Mar 5, 2019

Uh oh!

arturcic commented Mar 5, 2019

Uh oh!

arturcic commented Mar 5, 2019

Uh oh!

mr-exz commented Mar 5, 2019

Uh oh!

arturcic commented Mar 5, 2019

Uh oh!

mr-exz commented Mar 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arturcic commented Mar 5, 2019

Uh oh!

mr-exz commented Mar 5, 2019

Uh oh!

arturcic commented Mar 5, 2019

Uh oh!

mr-exz commented Mar 5, 2019

Uh oh!

asbjornu commented Mar 6, 2019

Uh oh!

arturcic commented Mar 6, 2019

Uh oh!

arturcic commented Mar 6, 2019

asbjornu commented Jan 21, 2019 •

edited

Loading

mr-exz commented Jan 21, 2019 •

edited

Loading

asbjornu Jan 22, 2019 •

edited

Loading

asbjornu Jan 22, 2019 •

edited

Loading

mr-exz commented Mar 5, 2019 •

edited

Loading