Skip to content

Add unit tests for MergeMessage class #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2018
Merged

Add unit tests for MergeMessage class #1484

merged 2 commits into from
Oct 2, 2018

Conversation

Kieranties
Copy link
Contributor

Introduces a number of unit tests for each regex in the MergeMessage class.

I intend on working on some additional features around this class and wanted to ensure the base implementation is covered with tests first.

@Kieranties
Copy link
Contributor Author

Kieranties commented Sep 28, 2018

Initial refactoring of the MergeMessage class and some resolutions to the 'TODOs' in this PR can be seen here: https://github.com/Kieranties/GitVersion/commit/13b7e5b139a1a0c2f8c13d1edae2bea22c8eec06

@asbjornu asbjornu merged commit 5b04e97 into GitTools:master Oct 2, 2018
@asbjornu
Copy link
Member

asbjornu commented Oct 2, 2018

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants