Improve shallow clone exception #1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asbjornu
force-pushed
the
feature/improve-shallow-clone-exception
branch
2 times, most recently
from
8484401 to
0667aeb
Compare
dazinator
requested changes
Sep 5, 2017
| using System.Runtime.Serialization; | ||
|
|
||
| [Serializable] | ||
| public class GitVersionException : ApplicationException |
There was a problem hiding this comment.
Would you consider deriving from GitToolsException instead : https://github.com/GitTools/GitTools.Core/blob/11fa325b9f7afa0f9d8abf12d260210f82a29e15/src/GitTools.Core/Exceptions/GitToolsException.cs - It will make it a bit easier to get this building under netstandard1.3 where ApplicationException isn't avialable, and it will also make exceptions accross the tools more consistent which I think was the purpose behind GitToolsException.
gep13
reviewed
Sep 6, 2017
| @@ -0,0 +1,32 @@ | |||
| #region License | |||
|
|
|||
| // -------------------------------------------------- | |||
There was a problem hiding this comment.
@asbjornu where is this license coming from?
There was a problem hiding this comment.
Good question. It's from ReSharper, but I thought GitVersion's DotSettings should override it? Either way, it's gone.
… the repository might be a shallow clone
asbjornu
force-pushed
the
feature/improve-shallow-clone-exception
branch
from
3e20f8e to
a90ce42
Compare
dazinator
approved these changes
Sep 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve upon the
LibGit2Sharp.NotFoundExceptionthrown when a commit ID can't be found due to a shallow clone by adding instructions to dogit fetch --unshallow. Fixes #1043.