Closes #1274 - Removed system.web (replaced databinder.eval) #1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have written a new implementation and to replace databinder.eval so that we can drop system.web as a dependency. System.Web should never have been adopted imho! Corrected docs.
Merged
asbjornu
reviewed
Aug 17, 2017
|
All of the following tests cover this (note they all pass, I just broke them temporarily so I could show you!) |
|
Merging.. Thanks for approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced databinder.eval and dropped system.web as a dependency. System.Web should never have been adopted imho :-)
This will unblock my open PR to add netstandard support.
Minor correction in docs.