Skip to content

Invalid release version when some branch created from it #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

czesiu
Copy link
Contributor

@czesiu czesiu commented Apr 19, 2017

I added test for problem with version calculating on release branch. When you create some branch from release branch then version calculating will take version from this other branch. I think that it is invalid result, but I don't know how to fix this.

Line 453:

fixture.AssertFullSemver(config, "2.0.0-beta.10");

throws exception:

Shouldly.ShouldAssertException : variables.FullSemVer should be "2.0.0-beta.10" but was "2.0.0-beta.2"

@JakeGinnivan JakeGinnivan self-requested a review May 11, 2017 11:28
@JakeGinnivan
Copy link
Contributor

JakeGinnivan commented May 21, 2017

This is actually a pretty hard problem to solve, but am having another crack at making it better. It may actually help GitVersion perform better.

Take your scenario: master -> release/ -> feature

If gitversion runs, it can't know if feature was branched from release or the other way around.. This is what is happening in your test, when you create the feature branch GitVersion thinks that release is now branched off the feature branch.

@JakeGinnivan
Copy link
Contributor

This issue should be fixed in #1225, I want to get feedback on the approach before I merge/release it though. If you can have a look at even the docs in that PR and check to see if the problem and the solution make sense to you that would be handy @czesiu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants