GitVersion does not update padded prerelease number

[jetersen]

Currently GitVersion always seemed to be padding with 0001

See: https://ci.appveyor.com/project/nmklotas/gitlabapiclient/builds/29847139#L84

GitVersion.yml config:

assembly-versioning-scheme: MajorMinorPatch
branches:
  master:
    tag: beta

[jetersen]

Test is missing for appveyor: https://github.com/GitTools/GitVersion/tree/master/src/GitVersionCore.Tests/BuildServers

[jetersen]

Even with UseFullSemVerForNuget set to true the padded prerelease number is not correct on appveyor

Set AppVeyor build number to '1.4.1-casz-patch-1.1+5'.
Executing GenerateBuildLogOutput for 'AppVeyor'.
Adding Environment Variable. name='GitVersion_Major' value='1']
Adding Environment Variable. name='GitVersion_Minor' value='4']
Adding Environment Variable. name='GitVersion_Patch' value='1']
Adding Environment Variable. name='GitVersion_PreReleaseTag' value='casz-patch-1.1']
Adding Environment Variable. name='GitVersion_PreReleaseTagWithDash' value='-casz-patch-1.1']
Adding Environment Variable. name='GitVersion_PreReleaseLabel' value='casz-patch-1']
Adding Environment Variable. name='GitVersion_PreReleaseNumber' value='1']
Adding Environment Variable. name='GitVersion_WeightedPreReleaseNumber' value='1']
Adding Environment Variable. name='GitVersion_BuildMetaData' value='5']
Adding Environment Variable. name='GitVersion_BuildMetaDataPadded' value='0005']
Adding Environment Variable. name='GitVersion_FullBuildMetaData' value='5.Branch.casz-patch-1.Sha.55211199652b1deeaaf0a45f642af7eb82555af7']
Adding Environment Variable. name='GitVersion_MajorMinorPatch' value='1.4.1']
Adding Environment Variable. name='GitVersion_SemVer' value='1.4.1-casz-patch-1.1']
Adding Environment Variable. name='GitVersion_LegacySemVer' value='1.4.1-casz-patch-1-1']
Adding Environment Variable. name='GitVersion_LegacySemVerPadded' value='1.4.1-casz-patch-1-0001']
Adding Environment Variable. name='GitVersion_AssemblySemVer' value='1.4.1.0']
Adding Environment Variable. name='GitVersion_AssemblySemFileVer' value='1.4.1.0']
Adding Environment Variable. name='GitVersion_FullSemVer' value='1.4.1-casz-patch-1.1+5']
Adding Environment Variable. name='GitVersion_InformationalVersion' value='1.4.1-casz-patch-1.1+5.Branch.casz-patch-1.Sha.55211199652b1deeaaf0a45f642af7eb82555af7']
Adding Environment Variable. name='GitVersion_BranchName' value='casz-patch-1']
Adding Environment Variable. name='GitVersion_Sha' value='55211199652b1deeaaf0a45f642af7eb82555af7']
Adding Environment Variable. name='GitVersion_ShortSha' value='5521119']
Adding Environment Variable. name='GitVersion_NuGetVersionV2' value='1.4.1-casz-patch-1-0001']
Adding Environment Variable. name='GitVersion_NuGetVersion' value='1.4.1-casz-patch-1-0001']
Adding Environment Variable. name='GitVersion_NuGetPreReleaseTagV2' value='casz-patch-1-0001']
Adding Environment Variable. name='GitVersion_NuGetPreReleaseTag' value='casz-patch-1-0001']
Adding Environment Variable. name='GitVersion_VersionSourceSha' value='c741517d9972046597bcfc542fd0b80e9557f93a']
Adding Environment Variable. name='GitVersion_CommitsSinceVersionSource' value='5']
Adding Environment Variable. name='GitVersion_CommitsSinceVersionSourcePadded' value='0005']
Adding Environment Variable. name='GitVersion_CommitDate' value='2020-01-02']
.\build.ps1
  Restore completed in 2.31 sec for C:\projects\gitlabapiclient\src\GitLabApiClient\GitLabApiClient.csproj.

[jetersen]

I looked over the code and the only logical place the bug is happening is here:

For some reason number is null

GitVersion/src/GitVersionCore/VersionCalculation/NextVersionCalculator.cs

Lines 95 to 118 in 495ba8a

	private void UpdatePreReleaseTag(GitVersionContext context, SemanticVersion semanticVersion, string branchNameOverride)
	{
	var tagToUse = GetBranchSpecificTag(context.Configuration, context.CurrentBranch.FriendlyName, branchNameOverride);
	int? number = null;
	var lastTag = context.RepositoryMetadataProvider
	.GetVersionTagsOnBranch(context.CurrentBranch, context.Configuration.GitTagPrefix)
	.FirstOrDefault(v => v.PreReleaseTag.Name == tagToUse);
	if (lastTag != null &&
	MajorMinorPatchEqual(lastTag, semanticVersion) &&
	lastTag.PreReleaseTag.HasTag())
	{
	number = lastTag.PreReleaseTag.Number + 1;
	}
	if (number == null)
	{
	number = 1;
	}
	semanticVersion.PreReleaseTag = new SemanticVersionPreReleaseTag(tagToUse, number);
	}

[jetersen]

Both GitVersion_BuildMetaData and GitVersion_CommitsSinceVersionSource is numbered correctly yet GitVersion_PreReleaseNumber is repoted as 1

[asbjornu]

Might #2003 improve on this in any way?

[pi3k14]

I looked over the code and the only logical place the bug is happening is here:

For some reason number is null

GitVersion/src/GitVersionCore/VersionCalculation/NextVersionCalculator.cs

Lines 95 to 118 in 495ba8a

	private void UpdatePreReleaseTag(GitVersionContext context, SemanticVersion semanticVersion, string branchNameOverride)
	{
	var tagToUse = GetBranchSpecificTag(context.Configuration, context.CurrentBranch.FriendlyName, branchNameOverride);
	int? number = null;
	var lastTag = context.RepositoryMetadataProvider
	.GetVersionTagsOnBranch(context.CurrentBranch, context.Configuration.GitTagPrefix)
	.FirstOrDefault(v => v.PreReleaseTag.Name == tagToUse);
	if (lastTag != null &&
	MajorMinorPatchEqual(lastTag, semanticVersion) &&
	lastTag.PreReleaseTag.HasTag())
	{
	number = lastTag.PreReleaseTag.Number + 1;
	}
	if (number == null)
	{
	number = 1;
	}
	semanticVersion.PreReleaseTag = new SemanticVersionPreReleaseTag(tagToUse, number);
	}

The only reason for number to be null is if lastTag is not found
What is the relevance of the GitVersion.yml?
You logg show branch name 'casz-patch-1'.

[jetersen]

@pi3k14 is in another build that perhaps interesting: https://ci.appveyor.com/project/nmklotas/gitlabapiclient/builds/29847139#L84
https://ci.appveyor.com/project/nmklotas/gitlabapiclient/builds/29852150#L85

[pi3k14]

@Casz - yepp :)

If I am reading the log correctly the fix in #2003 should correct this.

[jetersen]

Consider it closed than once I validate the #2003 patch 👏

[jetersen]

Did no solve the problem:
https://ci.appveyor.com/project/nmklotas/gitlabapiclient/builds/29874768#L99
😭

[pi3k14]

On 'casz-patch-1'?

[jetersen]

it's just a branch name it should still work.

[jetersen]

Locally on gitlabapiclient master branch I get this:

$ dotnet gitversion /version
5.1.4-beta.1+11.Branch.master.Sha.5ba22aed00c8c4156de18e5d7ce5ddfb5fa69870

$ dotnet gitversion
{
  "Major":1,
  "Minor":4,
  "Patch":1,
  "PreReleaseTag":"beta.1",
  "PreReleaseTagWithDash":"-beta.1",
  "PreReleaseLabel":"beta",
  "PreReleaseNumber":1,
  "WeightedPreReleaseNumber":55001,
  "BuildMetaData":2,
  "BuildMetaDataPadded":"0002",
  "FullBuildMetaData":"2.Branch.master.Sha.a78dc15a9a4b0a8d8bce82f828a8c25f2d3f9607",
  "MajorMinorPatch":"1.4.1",
  "SemVer":"1.4.1-beta.1",
  "LegacySemVer":"1.4.1-beta1",
  "LegacySemVerPadded":"1.4.1-beta0001",
  "AssemblySemVer":"1.4.1.0",
  "AssemblySemFileVer":"1.4.1.0",
  "FullSemVer":"1.4.1-beta.1+2",
  "InformationalVersion":"1.4.1-beta.1+2.Branch.master.Sha.a78dc15a9a4b0a8d8bce82f828a8c25f2d3f9607",
  "BranchName":"master",
  "Sha":"a78dc15a9a4b0a8d8bce82f828a8c25f2d3f9607",
  "ShortSha":"a78dc15",
  "NuGetVersionV2":"1.4.1-beta0001",
  "NuGetVersion":"1.4.1-beta0001",
  "NuGetPreReleaseTagV2":"beta0001",
  "NuGetPreReleaseTag":"beta0001",
  "VersionSourceSha":"c741517d9972046597bcfc542fd0b80e9557f93a",
  "CommitsSinceVersionSource":2,
  "CommitsSinceVersionSourcePadded":"0002",
  "CommitDate":"2020-01-02"
}

5.1.4-beta.1+11 should be the correct the one with the fix.

dotnet tool update -g GitVersion.Tool --version 5.1.4-beta1.11

[pi3k14]

Ah, you haven't set up your branch to use 'continuous deployment mode'.

Ref. https://gitversion.net/docs/git-branching-strategies/gitflow-examples and delivery vs. deployment.