-
Notifications
You must be signed in to change notification settings - Fork 654
VS2017 GitVersionTask for netstandard13 yields duplicate attributes on Build, foiled by AssemblyInfo autogen #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Try disabling the new assembly info generation feature https://github.com/Particular/NServiceBus.Ninject/blob/develop/src/NServiceBus.Ninject/NServiceBus.Ninject.csproj#L7 |
If you don't want to disable the assemblyinfo generation feature entirely, you can instead add the following to your project file:
|
mil gracias!
…On Wed, Jun 28, 2017 at 4:29 PM, Brandon Ording ***@***.***> wrote:
@tofutim <https://github.com/tofutim> In addition to the workarounds
listed here, this is fixed in the latest 4.0 beta release, though there are
some side effects: #1241
<#1241>, #1242
<#1242>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1231 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJoRsZTJjhB7NxD5pNXVss853UyUM6kks5sIuHcgaJpZM4NzjuQ>
.
|
Is this actually resolved? I am using the Azure DevOps task (4.0.0.4) and it doesn't work out of the box with the new project system. I have to put these into every project to avoid the Duplicate Attribute exception:
Is that expected? |
This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions. |
Uh oh!
There was an error while loading. Please reload this page.
I'm quite fond of GitVersionTask. Sadly, I'm seeing some issues with VS2017. To replicate the issue,
<PackageTargetFallback Condition=" '$(TargetFramework)' == 'netstandard1.3' ">portable-net45+win81</PackageTargetFallback>
Note: This worked in VS2015. Though I had to comment out the properties. Doesn't seem that there is a way to do so in the VS2015 library (no Properties folder). Any tips much appreciated.
Update. Looks like it is possible to prevent autogeneration of the AssemblyInfo per https://stackoverflow.com/questions/42138418/equivalent-to-assemblyinfo-in-dotnet-core-csproj though I wonder what this means for the nuget pack feature. Looks like autogeneration comes from the nuget package specifications in Properties.
csproj looks like
I wonder if the only solution is to give on GitVersionTask and run it GitVersion after the fact but before compiling.... although I guess if it is not auto-generated Gitversion won't be able to modify it???
Update2. Looks like the only solution for now is
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
The text was updated successfully, but these errors were encountered: