Skip to content

Publish beta versions to VSTS marketplace #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
pascalberger opened this issue Feb 2, 2017 · 21 comments
Closed
2 tasks

Publish beta versions to VSTS marketplace #1150

pascalberger opened this issue Feb 2, 2017 · 21 comments

Comments

@pascalberger
Copy link
Member

pascalberger commented Feb 2, 2017

VSTS marketplace seems to now support pre-release versions and the ability to select the version of an extension which should be used (See discussion here). Therefore we can publish the VSTS extension also for beta versions.

Required changes:

  • In case of beta release the VSTS extension needs to be build with the preview flag in the manifest
  • For beta releases the VSTS extension needs to be deployed to the VSTS marketplace
@SamirHafez
Copy link

SamirHafez commented Feb 4, 2017

Is this gonna go soon? Anything I can help with?

As far as deplying beta releases it could be as simple as removing this loc:

.WithCriteria(() => !tag.Contains("-")) // Do not release pre-release to VSTS

changing the vsix creator to inject the flag based on version (https://github.com/GitTools/GitVersion/blob/416ed5ad41a2699bc1dc9fd0731aae1909e1cfdd/src/GitVersionTfsTask/Create-Vsix.ps1) would be more complex

@pascalberger
Copy link
Member Author

@SamirHafez Are you interested in writing a PR implementing this?

There currently also is an effort undergoing to rewrite the VSTS task to use the Node handler instead of the PowerShell one, also affecting the build pipeline (See #1139). But this still takes some time until it is ready to be merged.

@sandorfr
Copy link

sandorfr commented Feb 4, 2017

Interesting, @pascalberger I'll think about it as we definitely want this feature for our other extensions.

@SamirHafez
Copy link

@pascalberger seems simple but I'd need input on what exactly to do on what files. Someone who implemented this build mechanism can probably turn this into a 5min PR lol

@Franklin89
Copy link

@pascalberger any news on this? the vsts task in the market place is already pretty old and is missing things like Mainline mode which i would like to use.

@pascalberger
Copy link
Member Author

@Franklin89 The version in the marketplace is still the latest stable release since no stable 4.0 release is out.

The switch to use the Node handler instead of the PowerShell one is now merged with #1189, but there was no development done yet for supporting beta releases to be pushed to the marketplace.

@sandorfr
Copy link

And there is still the libgit2sharp which needs to be updated.

@andrassy
Copy link

+1

Anything me our my team can help with? Which libgit2sharp ticket still needs work?

As a short term workaround could anyone provide some step-by-step installation instructions. I'm struggling to figure out how to get the vsix installed into TFS - just getting an error about an invalid version in the manifest when attempting to install the betas (beta 11).

@Tankatronic
Copy link

This would be great. I'd love to to have the fix for #1074 available.

@asbjornu
Copy link
Member

asbjornu commented Oct 18, 2017

@andrassy, @Tankatronic: The problem mentioned by @SamirHafez in #1150 (comment) still needs to be fixed before pre-releases can be published to VSTS. If any of you are up for submitting a PR removing .WithCriteria(() => !tag.Contains("-")), I'll be happy to merge it!

Tankatronic pushed a commit to Tankatronic/GitVersion that referenced this issue Oct 18, 2017
@Tankatronic
Copy link

@asbjornu I opened PR #1312

@JakeGinnivan
Copy link
Contributor

Gonna give the PR a go, lets see what happens during the next release!

JakeGinnivan added a commit that referenced this issue Dec 5, 2017
#1150 Remove criteria preventing the download of prerelease versions …
@marceloavf
Copy link

Any update on this ?

@Daniel-Svensson
Copy link

Would really like to se version 4 as an option for the build task, is there a planned update?

@dennisroche
Copy link

dennisroche commented Apr 24, 2018

I just hit this as wanted to use mainline.

Temporary workaround was to bundle a copy of GitVersion.Commandline in a tools folder (remember to set .gitattributes for the binary files).

^ This didn't work :/

Replaced the task with cmd task

steps:
- script: 'GitVersion.exe $(Build.SourcesDirectory) /output buildserver /nofetch' 'tools/GitVersion' 

@dennisroche
Copy link

To summarise what is needed to get pre-release versions published to VSTS.

  • Remove the WithCriteria() from Cake Build
  • Switch to use the Node handler instead of the PowerShell
  • Supporting beta releases to be pushed to the marketplace

@asbjornu
Copy link
Member

Now that a lot of people want to get their hands on #1713, I assume it would be good to get a beta version out to Azure DevOps. It doesn't seem like much work, have you looked into what's required, @arturcic?

@arturcic
Copy link
Member

Now that a lot of people want to get their hands on #1713, I assume it would be good to get a beta version out to Azure DevOps. It doesn't seem like much work, have you looked into what's required, @arturcic?

I think the same issue - we need a valid PAT token for publishing. I'll get back to this soon

@asbjornu
Copy link
Member

I see. I thought we had made progress on that front. Anything I can assist with?

@arturcic
Copy link
Member

I'll let you know when I need some assistance in that area. For now I guess we can manually publish the artifacts from the build to the marketplace to have the people test it

@arturcic arturcic added this to the 5.0.0 milestone Jun 27, 2019
@arturcic
Copy link
Member

Will be fixed by #1492

@arturcic arturcic removed this from the 5.0.0 milestone Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests