Merge pull request #3820 from GitTools/dependabot/nuget/src/NUnit-4.0.1

(deps): Bump NUnit from 3.14.0 to 4.0.1 in /src

Author: arturcic

src/Directory.Packages.props

@@ -21,7 +21,7 @@
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
     <PackageVersion Include="Microsoft.Win32.Registry" Version="6.0.0-preview.5.21301.5" />
     <PackageVersion Include="NSubstitute" Version="5.1.0" />
-    <PackageVersion Include="NUnit" Version="3.14.0" />
+    <PackageVersion Include="NUnit" Version="4.0.1" />
     <PackageVersion Include="NUnit.Analyzers" Version="3.10.0" />
     <PackageVersion Include="NUnit3TestAdapter" Version="4.5.0" />
     <PackageVersion Include="Polly" Version="8.2.0" />

src/GitVersion.Core.Tests/Core/GitVersionToolDirectoryTests.cs

@@ -26,7 +26,7 @@ public void SetUp()
     [Test]
     public void FindsGitDirectory()
     {
-        try
+        var exception = Assert.Catch(() =>
         {
             var options = Options.Create(new GitVersionOptions { WorkingDirectory = workDirectory, Settings = { NoFetch = true } });
 
@@ -35,13 +35,8 @@ public void FindsGitDirectory()
             var gitVersionCalculator = sp.GetRequiredService<IGitVersionCalculateTool>();
 
             gitVersionCalculator.CalculateVersionVariables();
-        }
-        catch (Exception ex)
-        {
-            // `RepositoryNotFoundException` means that it couldn't find the .git directory,
-            // any other exception means that the .git was found but there was some other issue that this test doesn't care about.
-            Assert.IsNotAssignableFrom<RepositoryNotFoundException>(ex);
-        }
+        });
+        exception.ShouldNotBeAssignableTo<RepositoryNotFoundException>();
     }
 
     [Test]
@@ -50,7 +45,7 @@ public void FindsGitDirectoryInParent()
         var childDir = PathHelper.Combine(this.workDirectory, "child");
         Directory.CreateDirectory(childDir);
 
-        try
+        var exception = Assert.Catch(() =>
         {
             var options = Options.Create(new GitVersionOptions { WorkingDirectory = childDir, Settings = { NoFetch = true } });
 
@@ -59,13 +54,7 @@ public void FindsGitDirectoryInParent()
             var gitVersionCalculator = sp.GetRequiredService<IGitVersionCalculateTool>();
 
             gitVersionCalculator.CalculateVersionVariables();
-        }
-        catch (Exception ex)
-        {
-            // TODO I think this test is wrong.. It throws a different exception
-            // `RepositoryNotFoundException` means that it couldn't find the .git directory,
-            // any other exception means that the .git was found but there was some other issue that this test doesn't care about.
-            Assert.IsNotAssignableFrom<RepositoryNotFoundException>(ex);
-        }
+        });
+        exception.ShouldNotBeAssignableTo<RepositoryNotFoundException>();
     }
 }