update to better property name per review

Author: Applesauce314

docs/input/docs/usage/msbuild.md

@@ -260,24 +260,24 @@ variables: `Version`, `VersionPrefix`, `VersionSuffix`, `PackageVersion`,
 
 ### Namespace generation
 
-You can configure GitVersion to generate the `GitVersionInformation` class in a namespace that matches the current assembly. By default this class is created in the global namespace. If `GenerateGitVersionInformationInUniqueNamespace` is set to true, the `GitVersionInfomation` class will instead be generated in a namespace matching the current project. If the property `<RootNamespace>` is set that value will be used, otherwise the name of the project file is used. 
+You can configure GitVersion to generate the `GitVersionInformation` class in a namespace that matches the current assembly. By default this class is created in the global namespace. If `UseProjectNamespaceForGitVersionInformation` is set to true, the `GitVersionInfomation` class will instead be generated in a namespace matching the current project. If the property `<RootNamespace>` is set that value will be used, otherwise the name of the project file is used.
 
 ```xml
 <PropertyGroup>
   ...
-  <GenerateGitVersionInformationInUniqueNamespace>true</GenerateGitVersionInformationInUniqueNamespace>
+  <UseProjectNamespaceForGitVersionInformation>true</UseProjectNamespaceForGitVersionInformation>
   ...
 </PropertyGroup>
 ```
 
 ## Extra properties
 
-There are properties that correspont to certain 
+There are properties that correspont to certain
 [command line arguments](/docs/usage/cli/arguments) for GetVersion task.
-In particular, setting `GitVersion_NoFetchEnabled` to `true` disables `git fetch` 
-during version calculation, setting `GitVersion_NoNormalizeEnabled` to `true` disables 
+In particular, setting `GitVersion_NoFetchEnabled` to `true` disables `git fetch`
+during version calculation, setting `GitVersion_NoNormalizeEnabled` to `true` disables
 normalize step on a build server, setting `GitVersion_NoCacheEnabled` to `true`
-makes GetVersion ignore cache. All the rest command line arguments can be passed via 
+makes GetVersion ignore cache. All the rest command line arguments can be passed via
 `GitVersion_CommandLineArguments` variable.
 
 ## My Git repository requires authentication. What should I do?

src/GitVersion.Core/Options/GitVersionOptions.cs

@@ -13,7 +13,7 @@ public class GitVersionOptions
     public WixInfo WixInfo { get; } = new();
     public Settings Settings { get; } = new();
 
-    public bool UniqueNamespace { get; set; }
+
 
     public bool Init;
     public bool Diag;

src/GitVersion.Core/PublicAPI.Unshipped.txt

@@ -943,5 +943,3 @@ virtual GitVersion.Agents.BuildAgentBase.IsDefault.get -> bool
 virtual GitVersion.Agents.BuildAgentBase.PreventFetch() -> bool
 virtual GitVersion.Agents.BuildAgentBase.ShouldCleanUpRemotes() -> bool
 virtual GitVersion.Agents.BuildAgentBase.WriteIntegration(System.Action<string?>! writer, GitVersion.OutputVariables.GitVersionVariables! variables, bool updateBuildNumber = true) -> void
-GitVersion.GitVersionOptions.UniqueNamespace.get -> bool
-GitVersion.GitVersionOptions.UniqueNamespace.set -> void

src/GitVersion.MsBuild.Tests/Tasks/GenerateGitVersionInformationTest.cs

@@ -219,7 +219,7 @@ public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuildA
     }
 
     [TestCaseSource(nameof(Languages))]
-    public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuildAndUniqueNamespaceIsSpecifiedAndRootNamespaceIsSet(string language)
+    public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuildAndUseProjectNamespaceIsSpecifiedAndRootNamespaceIsSet(string language)
     {
         const string taskName = nameof(GenerateGitVersionInformation);
         const string outputProperty = nameof(GenerateGitVersionInformation.GitVersionInformationFilePath);
@@ -229,7 +229,7 @@ public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuildA
         using var result = ExecuteMsBuildExe(project =>
         {
             var intermediateOutputPath = Path.Combine("$(MSBuildProjectDirectory)", randDir);
-            AddGenerateGitVersionInformationTask(project, taskName, taskName, outputProperty, language, intermediateOutputPath).Property("GenerateGitVersionInformationInUniqueNamespace", "True").Property("RootNamespace", "Test.Root");
+            AddGenerateGitVersionInformationTask(project, taskName, taskName, outputProperty, language, intermediateOutputPath).Property("UseProjectNamespaceForGitVersionInformation", "True").Property("RootNamespace", "Test.Root");
         }, language);
 
         result.ProjectPath.ShouldNotBeNullOrWhiteSpace();
@@ -253,7 +253,7 @@ public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuildA
     }
 
     [TestCaseSource(nameof(Languages))]
-    public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuildAndUniqueNamespaceIsSpecifiedAndRootNamespaceIsNotSet(string language)
+    public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuildAndUseProjectNamespaceIsSpecifiedAndRootNamespaceIsNotSet(string language)
     {
         const string taskName = nameof(GenerateGitVersionInformation);
         const string outputProperty = nameof(GenerateGitVersionInformation.GitVersionInformationFilePath);
@@ -263,7 +263,7 @@ public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuildA
         using var result = ExecuteMsBuildExeInAzurePipeline(project =>
         {
             var intermediateOutputPath = Path.Combine("$(MSBuildProjectDirectory)", randDir);
-            AddGenerateGitVersionInformationTask(project, taskName, taskName, outputProperty, language, intermediateOutputPath).Property("GenerateGitVersionInformationInUniqueNamespace", "True");
+            AddGenerateGitVersionInformationTask(project, taskName, taskName, outputProperty, language, intermediateOutputPath).Property("UseProjectNamespaceForGitVersionInformation", "True");
         }, language);
 
         result.ProjectPath.ShouldNotBeNullOrWhiteSpace();
@@ -285,13 +285,13 @@ public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuildA
     }
 
     [TestCaseSource(nameof(Languages))]
-    public void GenerateGitVersionInformationTaskShouldCreateFileWithUniqueNamespaceSetAndRootNamespaceUnSet(string language)
+    public void GenerateGitVersionInformationTaskShouldCreateFileWithUseProjectNamespaceSetAndRootNamespaceUnSet(string language)
     {
         var extension = FileHelper.GetFileExtension(language);
         var task = new GenerateGitVersionInformation
         {
             Language = language,
-            GenerateGitVersionInformationInUniqueNamespace = "true",
+            UseProjectNamespaceForGitVersionInformation = "true",
             ProjectFile = "App.Project.csproj",
         };
         using var result = ExecuteMsBuildTask(task);
@@ -311,14 +311,14 @@ public void GenerateGitVersionInformationTaskShouldCreateFileWithUniqueNamespace
     }
 
     [TestCaseSource(nameof(Languages))]
-    public void GenerateGitVersionInformationTaskShouldCreateFileWithUniqueNamespaceSetAndRootNamespaceIsSet(string language)
+    public void GenerateGitVersionInformationTaskShouldCreateFileWithUseProjectNamespaceSetAndRootNamespaceIsSet(string language)
     {
 
         var extension = FileHelper.GetFileExtension(language);
         var task = new GenerateGitVersionInformation
         {
             Language = language,
-            GenerateGitVersionInformationInUniqueNamespace = "true",
+            UseProjectNamespaceForGitVersionInformation = "true",
             ProjectFile = "App.Project.csproj",
             RootNamespace = "App.Project.RootNamespace",
         };
@@ -356,7 +356,7 @@ private static ProjectCreator AddGenerateGitVersionInformationTask(ProjectCreato
                 { "ProjectFile", "$(MSBuildProjectFullPath)" },
                 { "Language", "$(Language)" },
                 { "IntermediateOutputPath", intermediateOutputPath },
-                { "GenerateGitVersionInformationInUniqueNamespace", "$(GenerateGitVersionInformationInUniqueNamespace)" },
+                { "UseProjectNamespaceForGitVersionInformation", "$(UseProjectNamespaceForGitVersionInformation)" },
                 { "RootNamespace", "$(RootNamespace)" },
             })
             .TaskOutputProperty(outputProperty, outputProperty)

src/GitVersion.MsBuild/GitVersionTaskExecutor.cs

@@ -78,7 +78,7 @@ public void GenerateGitVersionInformation(GenerateGitVersionInformation task)
         static string? getTargetNamespace(GenerateGitVersionInformation task)
         {
             string? targetNamespace = null;
-            if (string.Equals(task.GenerateGitVersionInformationInUniqueNamespace, "true", StringComparison.OrdinalIgnoreCase))
+            if (string.Equals(task.UseProjectNamespaceForGitVersionInformation, "true", StringComparison.OrdinalIgnoreCase))
             {
                 targetNamespace = task.RootNamespace;
                 if (string.IsNullOrWhiteSpace(targetNamespace))

src/GitVersion.MsBuild/PublicAPI.Unshipped.txt

@@ -98,7 +98,7 @@ override GitVersion.MsBuild.Tasks.GenerateGitVersionInformation.OnExecute() -> b
 override GitVersion.MsBuild.Tasks.GetVersion.OnExecute() -> bool
 override GitVersion.MsBuild.Tasks.UpdateAssemblyInfo.OnExecute() -> bool
 override GitVersion.MsBuild.Tasks.WriteVersionInfoToBuildLog.OnExecute() -> bool
-GitVersion.MsBuild.Tasks.GenerateGitVersionInformation.GenerateGitVersionInformationInUniqueNamespace.get -> string?
-GitVersion.MsBuild.Tasks.GenerateGitVersionInformation.GenerateGitVersionInformationInUniqueNamespace.set -> void
+GitVersion.MsBuild.Tasks.GenerateGitVersionInformation.UseProjectNamespaceForGitVersionInformation.get -> string?
+GitVersion.MsBuild.Tasks.GenerateGitVersionInformation.UseProjectNamespaceForGitVersionInformation.set -> void
 GitVersion.MsBuild.Tasks.GenerateGitVersionInformation.RootNamespace.get -> string!
 GitVersion.MsBuild.Tasks.GenerateGitVersionInformation.RootNamespace.set -> void

src/GitVersion.MsBuild/Tasks/GenerateGitVersionInformation.cs

@@ -13,7 +13,7 @@ public class GenerateGitVersionInformation : GitVersionTaskBase
     [Required]
     public string Language { get; set; } = "C#";
 
-    public string? GenerateGitVersionInformationInUniqueNamespace { get; set; }
+    public string? UseProjectNamespaceForGitVersionInformation { get; set; }
 
     public string RootNamespace { get; set; }
 

src/GitVersion.MsBuild/msbuild/tools/GitVersion.MsBuild.targets

@@ -101,7 +101,7 @@
                                        ProjectFile="$(MSBuildProjectFullPath)"
                                        IntermediateOutputPath="$(IntermediateOutputPath)"
                                        Language="$(Language)"
-                                       GenerateGitVersionInformationInUniqueNamespace="$(GenerateGitVersionInformationInUniqueNamespace)"
+                                       UseProjectNamespaceForGitVersionInformation="$(UseProjectNamespaceForGitVersionInformation)"
                                        RootNamespace="$(RootNamespace)">
 
             <Output TaskParameter="GitVersionInformationFilePath" PropertyName="GitVersionInformationFilePath" />