Skip to content

Commit 730ffc7

Browse files
committed
docs(schemas): add TODOs regarding custom patterns for date-time formats
1 parent ae2c1b5 commit 730ffc7

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

schemas/5.12/GitVersion.configuration.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
},
5353
"commit-date-format": {
5454
"format": "date-time",
55-
"pattern": "\u0027yyyy-MM-dd\u0027",
55+
"pattern": "yyyy-MM-dd", // ! TODO: Remove unless we want a format that does not conform to RFC 3339. If we want a custom format, rewrite this pattern in RegEx while somehow accounting for impossible dates i.e. leap days in non-leap years, 31st day in shorter months, et cetera.
5656
"description": "The format to use when calculating the commit date. Defaults to \u0027yyyy-MM-dd\u0027.",
5757
"type": "string"
5858
},

schemas/6.0/GitVersion.configuration.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
},
4747
"commit-date-format": {
4848
"format": "date-time",
49-
"pattern": "\u0027yyyy-MM-dd\u0027",
49+
"pattern": "yyyy-MM-dd", // ! TODO: rewrite pattern. Should account for leap years and each month's respective
5050
"description": "The format to use when calculating the commit date. Defaults to \u0027yyyy-MM-dd\u0027.",
5151
"type": "string"
5252
},

0 commit comments

Comments
 (0)